Physics separation merge: Step 11 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call to edmf_run
…ent to edmf_run call in GFS_physics_driver to array
-fixed compilation issue that Chris found due to Grant's doxygen changes
|
@llpcarson @mzhangw this PR contains the bugfix I mentioned in my email Friday last week regarding the uninitialized variables ictmglg, isolar in GFS_time_vary_step. The reason why this didn't show up in your BFB tests earlier is that these local variables were presumably initialized to zero and that the (correct) values defined in the input.nml namelist are also zero for both. |
|
ok. |
mzhangw
approved these changes
Dec 27, 2017
mzhangw
approved these changes
Dec 27, 2017
mzhangw
approved these changes
Dec 27, 2017
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Jun 5, 2020
Cleanup of radiation (clouds) - microphysics interaction (based on NCAR#33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the work of @grantfirl and @mzhangw on the GFS_time_vary subroutines. Tested BFB on Theia (32-bit, non-hydrostatic, prod) and Cheyenne (64-bit, non-hydrostatic, prod).
The commit history is confusing, since different branches were used for the development, but the changes to the code are confined to four files only.