Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no-MPI compilation for F-A scheme #363

Merged
merged 1 commit into from
Dec 3, 2019
Merged

fix no-MPI compilation for F-A scheme #363

merged 1 commit into from
Dec 3, 2019

Conversation

grantfirl
Copy link
Collaborator

  • add preprocessor directive around MPI_BCAST statements for non-MPI compilation with SCM

IMO, no RTs required.

grantfirl
grantfirl commented Dec 2, 2019
View reviewed changes
physics/module_MP_FER_HIRES.F90
call MPI_ABORT(MPI_COMM_COMP, rc, IRTN)
#endif
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that I could put an #else STOP here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, set ccpp_errflg/msg and return since we're not supposed to STOP in a scheme?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do that in either case - set errmsg and errflg and return, not even worrying about MPI_ABORT or STOP.

@grantfirl grantfirl mentioned this pull request Dec 2, 2019
Merged
@climbfuji
Copy link
Collaborator

@grantfirl I already merged the PR for SCM. I will thus merge this PR as a temporary fix and hope for another PR that uses errmsg/errflg instead of aborting the model. Thanks!

climbfuji
climbfuji approved these changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as temporary workaround.

@climbfuji climbfuji merged commit 7041bd2 into NCAR:dtc/develop Dec 3, 2019
@grantfirl grantfirl mentioned this pull request Dec 3, 2019
Merged
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
@climbfuji @mzhangw @mark-a-potts
Wrapper PR for NCAR#366 (remove redundant surface variables) and NCAR…
6bad820 
…#363 (send correct pointers to JEDI) (NCAR#368)

* clean up redundant surface variables
* Updates to send correct pointers to JEDI 

Co-authored-by: man.zhang <Man.Zhang@noaa.gov>
Co-authored-by: Mark Potts <Mark.Potts@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climbfuji climbfuji climbfuji approved these changes

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantfirl @climbfuji