Fix longname conflicts 20180110 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E to DERIVED_TYPE
…n: Diag%dq3dt(:,:,6) should be Diag%dq3dt(:,:,4)
…ormatting in GFS_physics_driver.F90
…units for count-type variables (that used to have index as unit)
…ings that certain parts of the code must be removed once the physics are integrated with the CCPP
…Model%... variables
… fix_longname_conflicts
|
These changes look good to me, Dom. Do we need to follow up with @mzhangw regarding the argument passed into GFS_MP_generic_post_run? Also, I noticed that commit Shall I look into what to do with lines 561-573 in GFS_physics_driver.F90 that you mentioned in that commit? |
|
@grantfirl @mzhangw Man already confirmed that this bug should be fixed - I will do this in the following round, then. Smaller chunks are easier to digest, I guess. |
grantfirl
approved these changes
Jan 10, 2018
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Apr 7, 2020
* fv3atm issue NCAR#37: fix the real(8) lat/lon in netcdf file * fv3atm NCAR#35: Reducing background vertical diffusivities in the inversion layers * fv3atm NCAR#24: bug in gfsphysics/physics/moninedmf_hafs.f * fv3atm NCAR#18: Optimize netcdf write component and bugfix for post and samfdeepcnv.f * set (0-1) bounds for ficein_cpl * remove cache_size due to lower netcdf verion 4.5.1 on mars * Change ice falling to 0.9 in gfsphysics/physics/gfdl_cloud_microphys.F90
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Jun 25, 2020
…ter_20200616 Update gsd/develop from master 2020/06/16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the second round of fixing longname conflicts. In several metadata tables, indices, variable longnames (spelling!), ranks and units are corrected.
Most notably, several local variables defined in GFS_physics_driver.F90 that were straight static copies of Model%... variables were removed.
Code tested bfb on Cheyenne.