add preliminary satmedmfvdifq documentation #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantfirl
requested review from
climbfuji,
JulieSchramm and
llpcarson
as code owners
|
@mzhangw I'm guessing that this needs to be pulled into the branch that you have for the release documentation. Feel free to do whatever you need to do to get this to work with what you already have. |
|
Thanks. I will consolidate it with my SCI doc branch. |
|
My understanding is that this content is now in the ufs_public_release branch. Can this PR be closed? |
|
Your understanding is correct.
…On Wed, Jan 22, 2020 at 4:21 PM ligiabernardet ***@***.***> wrote:
My understanding is that this content is now in the ufs_public_release
branch. Can this PR be closed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#371?email_source=notifications&email_token=AG7TW2VJCFU3VD37Y6436N3Q7DIGLA5CNFSM4J2TNFGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJVOZGQ#issuecomment-577432730>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2XPKEOMH7ECJX7XM3TQ7DIGLANCNFSM4J2TNFGA>
.
|
|
Nonetheless, this should still go to dtc/develop, or? |
climbfuji
reviewed
Feb 5, 2020
|
I think it is already included in the ufs_public_release branch.
…On Tue, Feb 4, 2020 at 5:09 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
This looks good to me. I am going to pull this into a larger commit
combining several small commits, no need to merge it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#371?email_source=notifications&email_token=AG7TW2RH3FPLPQAC4ZVSPM3RBH7UHA5CNFSM4J2TNFGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUIFC2Q#pullrequestreview-353390954>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2VHETZHI6D2ZRONBCTRBH7UHANCNFSM4J2TNFGA>
.
|
Yes, but this PR is for dtc/develop (see conversation above). |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
… suite definition files (NCAR#371) * address error entered in stochastic_physics_wrapper.F90 that broke the ca restart reproducibility * Remove scheme rayleigh_damp from all remaining suite definition files Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of documentation for satmedmfvdifq. There are some formatting snafus, but that is not unique to this scheme. Sometimes, it seems like doxygen has a mind of its own with how it parses fortran documentation.