Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmtb gfsphysics reduce op sfc_sice #47

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Gmtb gfsphysics reduce op sfc_sice #47

merged 1 commit into from
Mar 12, 2018

Conversation

climbfuji
Copy link
Collaborator

This PR modifies the compiler optimization flags for sfc_sice.f when using the Intel compiler: instead of "-O2 -xCORE-AVX2", "-O1 -xCORE-AVX-I" are used.

The reason for this change is that with the standard optimization flags for PROD runs are used, the results of the model run change when certain arguments (e.g. fixed-length characters) are added to the argument list. The differences are small (1e-15) for each call to the scheme, but propagate quickly and modify the answers of the model run. The differences when adding arguments to the call to sfc_sice_run() are due to different optimization paths the Intel compiler can take, resulting in differences in the snetw and sneti calculation in lines 347-349, which are handed down to the internal subroutine ice3lay and subsequently modify the results of the intent(inout) variable gflux.

Note that this PR changes the results of the model run with the Intel compiler on Theia and Cheyenne. This needs to be noted for future integration with the trunk. New baseline runs are required after this PR is merged. The differences in runtime are negligible and several orders smaller than the variability from run to run on Theia.

@climbfuji
Copy link
Collaborator Author

This is a screen shot of the differences when adding a new argument of type character(len=FIXED) to the argument list of sfc_sice_run:

XXX VARIABLE MPITASK OMPTHREAD BLOCKNUMBER COLUMN_IN_BLOCK VALUE, left without the additional argument, right with the additional argument.

screen shot 2018-03-09 at 1 57 55 pm

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji climbfuji merged commit facdee5 into NCAR:features/ccpp Mar 12, 2018
@climbfuji climbfuji deleted the gmtb-gfsphysics-reduce-opt-sfc_sice branch March 12, 2018 16:43
climbfuji pushed a commit to climbfuji/ccpp-physics that referenced this pull request Sep 3, 2020
Changes for flexible number of soil levels.
XiaqiongZhou-NOAA pushed a commit to XiaqiongZhou-NOAA/ccpp-physics that referenced this pull request Apr 7, 2023
sync with the new community repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants