Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the compiler optimization flags for sfc_sice.f when using the Intel compiler: instead of "-O2 -xCORE-AVX2", "-O1 -xCORE-AVX-I" are used.
The reason for this change is that with the standard optimization flags for PROD runs are used, the results of the model run change when certain arguments (e.g. fixed-length characters) are added to the argument list. The differences are small (1e-15) for each call to the scheme, but propagate quickly and modify the answers of the model run. The differences when adding arguments to the call to sfc_sice_run() are due to different optimization paths the Intel compiler can take, resulting in differences in the snetw and sneti calculation in lines 347-349, which are handed down to the internal subroutine ice3lay and subsequently modify the results of the intent(inout) variable gflux.
Note that this PR changes the results of the model run with the Intel compiler on Theia and Cheyenne. This needs to be noted for future integration with the trunk. New baseline runs are required after this PR is merged. The differences in runtime are negligible and several orders smaller than the variability from run to run on Theia.