Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move_zorl_interstitial
…move_zorl_interstitial
…rface_composites_pre_run
…move_zorl_interstitial
…ace composites from ocean to water
This was referenced Apr 5, 2021
|
The change of standard names to use over_water instead of over_ocean is good to avoid confusion. |
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
ShanSunNOAA
reviewed
Apr 5, 2021
physics/GFS_debug.F90
Outdated
| @@ -436,6 +436,8 @@ subroutine GFS_diagtoscreen_run (Model, Statein, Stateout, Sfcprop, Coupling, | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorl' , Sfcprop%zorl) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorlo' , Sfcprop%zorlo) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorll' , Sfcprop%zorll) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorli' , Sfcprop%zorli) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorlw' , Sfcprop%zorlw) | |||
There was a problem hiding this comment.
Are zorlo and zorlw for ocean and water, respectively? Are they the same?
There was a problem hiding this comment.
Thanks for pointing this out. I have not renamed the Sfcprop constituents yet, exactly because I wasn't sure what to do with Sfcprop%zorlw - make this Sfcprop%zorlwav and use Sfcprop%zorlw for water? Would that be confusing?
There was a problem hiding this comment.
Got it. zorlwav would be good for me. Thanks.
There was a problem hiding this comment.
@shansun6 @SMoorthi-emc I renamed Sfcprop%zorlw to Sfcprop%zorlwav in #596, and then in this PR Sfcprop%zorlo to Sfcprop%zorlw. Doing this in two steps ensures that I am not mistakenly using the wrong values.
|
zorlw is for waves.
…On Mon, Apr 5, 2021 at 12:43 PM shansun6 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/GFS_debug.F90
<#609 (comment)>:
> @@ -436,6 +436,8 @@ subroutine GFS_diagtoscreen_run (Model, Statein, Stateout, Sfcprop, Coupling,
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorl' , Sfcprop%zorl)
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorlo' , Sfcprop%zorlo)
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorll' , Sfcprop%zorll)
+ call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorli' , Sfcprop%zorli)
+ call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorlw' , Sfcprop%zorlw)
Are zorlo and zorlw for ocean and water, respectively? Are they the same?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#609 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYUKITGAY6XOPDRW663THHSD3ANCNFSM42M3PQPA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
ShanSunNOAA
approved these changes
Apr 5, 2021
physics/GFS_debug.F90
Outdated
| @@ -436,6 +436,8 @@ subroutine GFS_diagtoscreen_run (Model, Statein, Stateout, Sfcprop, Coupling, | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorl' , Sfcprop%zorl) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorlo' , Sfcprop%zorlo) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorll' , Sfcprop%zorll) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorli' , Sfcprop%zorli) | |||
| call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Sfcprop%zorlw' , Sfcprop%zorlw) | |||
There was a problem hiding this comment.
Got it. zorlwav would be good for me. Thanks.
|
…e no longer existant Interstitial%dtdtc
…ji/ccpp-physics into rename_surface_composites_ocean_water
…ocean to _water, rename Sfcprop%zorlo to Sfcprop%zorlw
|
It is a bit confusing looking at code changes in this format. I guess there are plenty of changes in "gfdl_sfc_layer.F90" |
SMoorthi-emc
approved these changes
Apr 6, 2021
llpcarson
approved these changes
Apr 14, 2021
XiaSun-Atmos
approved these changes
Apr 14, 2021
grantfirl
approved these changes
Apr 14, 2021
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
* update atmos_cubed_sphere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames Fortran variables and CCPP standard names / long names of surface composites from "ocean" to "water", since these also contain lake points.
Note that this PR contains all the changes in #596. #596 can be merged independently before this PR, or as part of this PR.
Fixes #455.
Associated PRs:
#609
NOAA-EMC/fv3atm#271
ufs-community/ufs-weather-model#508
For regression testing, see ufs-community/ufs-weather-model#508