Sm may182021 #662
Sm may182021 #662
Conversation
…e result in non fractional grid result
This reverts commit 5d50830.
…a has becom very slow
…restart reproducing with frac_grid=.true.
…truereproduces continuous run in REPRO mode
|
Ben, I agree with you and I will change to using "log".for zorl compositing.
…On Wed, Jun 9, 2021 at 3:35 PM benwgreen ***@***.***> wrote:
Ben, since Jongil's PR goes ahead of mine, I will have to merge and see
what he does. I may have to change based on what he does. If he changes
what is there now in sfc-diff, that would change the scheme.
Okay, as long as you double-check uustar_wat after Jongil's commit goes
through, then my only remaining concern is about z0rl compositing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#662 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYVKRGDHMWPDN4356RTTR6673ANCNFSM45HAQLPA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
…tween water and ice following Ben Green's suggestion and removng a comment from gcycle
|
Hi Moorthi,
Thank you for your reply, and your very nice work on "gcycle".
Shan
…On Wed, Jun 9, 2021 at 5:27 PM SMoorthi-emc ***@***.***> wrote:
Shan, Just a bit of clarification. I did not see the line 131 on my cell
phone.
The code following "else" is in case there is no "landfrac" is available
and mask will fall back to non frac grid. It may not be needed, but just
added in case. The important part though are the lines above "else". Here
slmskl=1 if there is land and slmskw=0 if there is water. Thus with both
water and land there are two masks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#662 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVSB45MBWY3QS6XV6YLTR72E3ANCNFSM45HAQLPA>
.
|
|
Yes, I will check to see what changed.
Thanks for reminding me.
…On Thu, Jun 10, 2021 at 7:36 AM benwgreen ***@***.***> wrote:
***@***.**** approved this pull request.
All of my concerns have been resolved. Moorthi, don't forget to check
uustar_wat again after Jongil's PR665 goes in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#662 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYWR2MZU4PMZ3FFBNN3TSCPRZANCNFSM45HAQLPA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
While I agree that the choice of "-1.0E-8" is arbitrary, if landfrac is
less than that it will use slmsk defined in FV3GFS_io.
The function "nint" returns "1" if slmsk >=0.5. If it is less than 0.5, it
will return "0". I expect that "landfrac", if defined in the file would
have value between 0.0 and 1.0, but the machine representation of 0.0 could
be a very small positive or negative value. The logic I added would
eliminate setting slmskl to "1" when abs(landfrac) < 1.0e-8.
…On Tue, Jun 22, 2021 at 10:31 PM Jun Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/gcycle.F90
<#662 (comment)>:
> end if
!
+ if (frac_grid) then
+ do ix=1,npts
+ if (landfrac(ix) > -1.0e-8_kind_phys) then
+ slmskl(ix) = ceiling(landfrac(ix)-1.0e-8_kind_phys)
+ slmskw(ix) = floor(landfrac(ix)+1.0e-8_kind_phys)
+! slmskw(ix) = slmskl(ix)
+ else
would the round off error only happen when landfrac(ix) <-1.e-8 (e.g.
-1.e-7), so basically landfrac is around 0., could nint(slmsk(ix)) still be
1?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#662 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYXSSJAM3M6A66BETK3TUFBOXANCNFSM45HAQLPA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
Where is this PR within the UFS regression test process? There are some changes to the *_time_vary routines for FV3 that should probably be mirrored in the SCM versions, if nothing else for style consistency, that will not effect UFS RTs at all. @SMoorthi-emc could I add those and submit a PR into this branch? It is fine to wait and do it in a followup PR into ccpp-physics if you'd rather do that, it just might save code managers an extra step. |
|
Hi Grant,
Right now this PR is on hold as I am having some problems with rap and
hrrr regression tests.
So, we can include your updates.
Thanks
Moorthi
…On Fri, Jun 25, 2021 at 3:04 PM grantfirl ***@***.***> wrote:
Where is this PR within the UFS regression test process? There are some
changes to the *_time_vary routines for FV3 that should probably be
mirrored in the SCM versions, if nothing else for style consistency, that
will not effect UFS RTs at all. @SMoorthi-emc
<https://github.com/SMoorthi-emc> could I add those and submit a PR into
this branch? It is fine to wait and do it in a followup PR into
ccpp-physics if you'd rather do that, it just might save code managers an
extra step.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#662 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYXLQU3SYDFEOFAHAQTTUTHKPANCNFSM45HAQLPA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
…S_time_vary_pre.scm.F90 to match FV3 versions in ccpp-physics PR#662
Thanks, @SMoorthi-emc. Please see SMoorthi-emc#3 for the SCM-only updates. |
|
Regression testing with the ufs-weather-model completed successfully, will merge now. |
This version updates "gcycle" and "sfcsub" to handle fractional grid.
The emissivity of wate and ice in "GFS_surface_composites" is made consistent with those in radiation_surface".
There are several updates to "sfc_sice" to cleanaup plus add protection from crashing.
Several files are also changed as "ncld" variable is removed and "ncnd" is defined from "nwat" in GFS_Typedef.F90"
There are several other minor changes accumulated over several months.