CCPP metadata bug fixes and updates #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2021
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
…e_feature_capgen_into_main_20210812
climbfuji
force-pushed
the
merge_feature_capgen_into_main_20210812
branch
from
bdfcb99 to
93368e9
Compare
…e_feature_capgen_into_main_20210812
@dustinswales please re-review and approve if satisfied (your comment was about the rte-rrtmgp change, which I addressed; you merged the RRTMGP PR yesterday). Thanks! |
dustinswales
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates and bug fixes to the CCPP metadata and the metadata hooks in the Fortran code, required for consistency and a future update of the ccpp-framework.
Also: update of submodule pointer for rte-rrtmgp for similar updates.
Associated PRs:
NCAR/ccpp-framework#391
earth-system-radiation/rte-rrtmgp#133
#718
NOAA-EMC/fv3atm#367
ufs-community/ufs-weather-model#745
For regression testing, see ufs-community/ufs-weather-model#745.