Wrapper PR for "Remove optional arguments from CCPP metadata, remove effective radii computation from Thompson MP" (#763) and "Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions" (#752) #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneric_post_run to GFS_suite_interstitial_4_run (to be consistent with the corresponding logic in GFS_suite_interstitial_3_run
…nup-ccpp-october-2021
…_convective_transport_tracers_cleanup
…apper physics/mp_thompson.F90 (was disabled anyway, since done in radiation interstitials)
…ve_optional_arguments_from_ccpp
…_convective_transport_tracers_cleanup
…pp-physics into ccpp_convective_transport_tracers_cleanup
…_convective_transport_tracers_cleanup
…pp-physics into ccpp_convective_transport_tracers_cleanup
…ve_optional_arguments_from_ccpp
…_convective_transport_tracers_cleanup
…ve_optional_arguments_from_ccpp
…com/climbfuji/ccpp-physics into cleanup-ccpp-and-remove-optional-arguments
This was referenced Nov 2, 2021
Merged
climbfuji
changed the title
|
@grantfirl @llpcarson Please review this PR, if you can - we are hoping to merge this today. Moorthi and others already reviewed the individual PRs that this PR combines. Thanks! |
|
The original PRs that were combined here were reviewed by some of the subject matter experts. All regresssion tests passed. I am going to merge without review by the code owners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines #752 and #763, since none of the PRs changes the answers.
#752:
Fixes #751 (see there).
This is achieved by moving the logic to reset the second entry of the
clwarray (in cases when only one tracer is used) fromGFS_SCNV_generic_post_runtoGFS_suite_interstitial_4_run.Also adds a new debugging scheme
GFS_checktracerstoGFS_debug.{F90,meta}that can be used to detect negative tracers almost anywhere in the suite definition file (except thefast_physicsgroup).Further: correct spelling "janic" --> "janjic" in a few CCPP standard names.
Also: contains the changes in PR #755 (fix inconsistent types related with noahmp and log functions) from @uturuncoglu. Fixes #750.
#763:
Remove optional attributes from all CCPP metadata files.
Remove optional and unused effective radii calculation in Thompson MP wrapper (
mp_thompson.{F90,meta}). The effective radii calculation happens in the radiation interstitials, the code in the Thompson MP wrapper was not used.Associated PRs
NCAR/ccpp-framework#408
earth-system-radiation/rte-rrtmgp#143
#766
NOAA-EMC/fv3atm#416
ufs-community/ufs-weather-model#892
ESCOMP/CCPPStandardNames#23