Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure potential fix #137

Closed
wants to merge 1 commit into from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Nov 6, 2019

Clunky fix for issue #135

@grantfirl grantfirl changed the base branch from gmtb/develop to dtc/develop November 8, 2019 23:08
@climbfuji
Copy link
Collaborator

@grantfirl any update on this one? Did I volunteer to try something and then forget it?

@grantfirl
Copy link
Collaborator Author

grantfirl commented Dec 10, 2019

@grantfirl any update on this one? Did I volunteer to try something and then forget it?

The "fix" that I implemented here just notifies the user of the multi_run_gmtb_scm.py script if the word "error" shows up in the console output of the cases that it runs. So, the user will be notified of a non-zero exit code of the subprocesses OR the "error" string in the output. Definitely not ideal, but I don't have time to dig into why the run script returns a zero exit code for some errors and not others.

So, you can look at this PR and see if it is "good enough" for now or whether you think more time should be spent to fix it properly.

@grantfirl
Copy link
Collaborator Author

This has been implemented as part of the v5 release branch, which will get merged in from there. This can be closed.

@grantfirl grantfirl closed this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants