Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/develop: Python 3 compatibility (run scripts), standard_name updates #179

Merged

Conversation

climbfuji
Copy link
Collaborator

This PR:

  • updates the standard_name entries of several variables following the fix of issue Cleanup radiation tendencies ccpp-physics#179 (cleanup radiation tendencies)
  • adds Python 3 compatibility for scm/src/run_gmtb_scm.py and scm/src/multi_run_gmtb_scm.py
  • generates a report about successful/failed runs at the end of the multi-run script when the verbose flag is set
  • updates the submodule pointers for ccpp/framework and ccpp/physics to include the latest developments

This PR requires NCAR/ccpp-physics#426 to be merged first.

Tested on macOS with

  • LLVM clang + GNU gfortran without OpenMP in Debug (DEBUG) mode, using Python 2.7
  • GNU gcc+gfortran with OpenMP in PROD (Release) mode, using Python 3.7

…e standard names following the radiation tendency cleanup work
…atibility, generate report at end of multi-run script when verbose flag is set
@climbfuji climbfuji marked this pull request as ready for review April 3, 2020 21:08
…y.SourceFileLoader throw different exceptions
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. There weren't too many changes for python 3 in the run scripts it looks like, but it saved me some time figuring it out, so thanks! Approved.

@climbfuji
Copy link
Collaborator Author

@grantfirl do you want to test it first?

I am happy to accommodate any changes you may have as the primary gmtb-scm developer.

@grantfirl
Copy link
Collaborator

@grantfirl do you want to test it first?

I am happy to accommodate any changes you may have as the primary gmtb-scm developer.

I cloned this recursively (I have uncommitted changes in my working version), built and ran on my machine in python 2.7 and 3.6 environments. Everything worked as expected, including the new summary in verbose mode. The only thing that I noticed is that the verbose output in the multirun script using 3.6 was not parsing newline characters in the output correctly, so it looked terrible, but that isn't a huge deal and I can investigate that later.

@climbfuji
Copy link
Collaborator Author

@grantfirl do you want to test it first?
I am happy to accommodate any changes you may have as the primary gmtb-scm developer.

I cloned this recursively (I have uncommitted changes in my working version), built and ran on my machine in python 2.7 and 3.6 environments. Everything worked as expected, including the new summary in verbose mode. The only thing that I noticed is that the verbose output in the multirun script using 3.6 was not parsing newline characters in the output correctly, so it looked terrible, but that isn't a huge deal and I can investigate that later.

Yes, I noticed that, too. Must have to do with the Python 3.x way of treating strings as bytes. Maybe adding .decode() or something like that? For the future ... will merge now.

@climbfuji climbfuji merged commit dd5a5ef into NCAR:dtc/develop Apr 3, 2020
dustinswales pushed a commit to dustinswales/ccpp-scm that referenced this pull request May 16, 2022
…tendencies

dtc/develop: Python 3 compatibility (run scripts), standard_name updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants