Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCM code for CCPP merges from 2021/07/09 through 2021/09/21 #272

Merged
merged 10 commits into from
Sep 24, 2021

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Sep 20, 2021

This PR updates the SCM code to use the latest ccpp-physics main code as of 2021/09/21. Changes are analogous to those already merged into fv3atm.

Highlights:

  • uses new tendencies
  • uses new standard names
  • contains code updates to work with all physics changes since early July

This work was performed by updating the SCM code to correspond to pull requests in ccpp-physics in chronological merge order. SCM regression tests were run and passed with identical output for code changes corresponding to ccpp-physics PRs #679, #695, #665, #681, #702, #715, #701, #525,714,716,717,718,721,722 (combined) and #705.

@grantfirl
Copy link
Collaborator Author

Replaces #269 and #264.

@grantfirl
Copy link
Collaborator Author

grantfirl commented Sep 20, 2021

Requires changes in ccpp-physics: NCAR/ccpp-physics#731

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I understand you need ccpp-physics PR NCAR/ccpp-physics#731 merged first, which should happen today or tomorrow.

@grantfirl
Copy link
Collaborator Author

Looks good to me - I understand you need ccpp-physics PR NCAR/ccpp-physics#731 merged first, which should happen today or tomorrow.

OK, thanks. I see that #731 was pulled into #732. I don't think that the SCM needs any updates based on the other changes in #732, but after it is merged, I'll go ahead an re-run the SCM RTs to be safe and update the submodule pointers before merging this.

@grantfirl
Copy link
Collaborator Author

RTs were successful. Merging now...

@grantfirl grantfirl merged commit 219d0a9 into NCAR:main Sep 24, 2021
mkavulich pushed a commit that referenced this pull request May 12, 2022
Update SCM code for CCPP merges from 2021/07/09 through 2021/09/21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants