Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ugwp_driver_v0.f compilation warning fix #4

Merged
merged 1 commit into from
Nov 25, 2019
Merged

ugwp_driver_v0.f compilation warning fix #4

merged 1 commit into from
Nov 25, 2019

Conversation

grantfirl
Copy link
Collaborator

fix compilation warnings related to wrong arguments passed into 2 subroutines in ugwp_driver_v0.f (note that the code that generated the warnings is in a non-active section)

Associated PR: NCAR/ccpp-physics#354

@grantfirl
fix compilation warnings related to wrong arguments passed into 2 sub…
3dba65f 
…routines in ugwp_driver_v0.f (note that the code that generated the warnings is in a non-active section)
@grantfirl grantfirl mentioned this pull request Nov 22, 2019
Merged
@grantfirl
Copy link
Collaborator Author

Note that Valery has approved this fix.

@grantfirl
Copy link
Collaborator Author

@climbfuji Since this only affects non-active code, I don't see a point in running RTs, do you? If no RTs needed, this is ready to merge.

@climbfuji
Copy link
Collaborator

No need to run the regression tests. For merging, I would want to know that the code compiles with both Intel and GNU with both Debug and Release for SCM / DEBUG, PROD and REPRO for UFS. I am happy to check out the code and do the test compilations for UFS. Let me know. Thanks!

@grantfirl
Copy link
Collaborator Author

This compiles with SCM on Mac/Gnu Debug/Release and Hera/Intel Debug/Release. I'm assuming since this change is IPD and CCPP that you want CCPP=Y/N and REPRO=Y/N (4 total compilations). I'll start this, but I need to stop early today for my daughter's dance recital and then I'm gone for a week, so I'll let you know what I get through in terms of compilations with UFS.

@climbfuji
Copy link
Collaborator

This compiles with SCM on Mac/Gnu Debug/Release and Hera/Intel Debug/Release. I'm assuming since this change is IPD and CCPP that you want CCPP=Y/N and REPRO=Y/N (4 total compilations). I'll start this, but I need to stop early today for my daughter's dance recital and then I'm gone for a week, so I'll let you know what I get through in terms of compilations with UFS.

Great, thank you. I'll do whatever you couldn't complete. Just post the directory with the code on hera, please, so that I do not have to check it out manually.

@grantfirl
Copy link
Collaborator Author

grantfirl commented Nov 22, 2019 •
edited
Loading

UFS Compiles with the following MAKEOPTS on Hera/Intel:
REPRO=Y CCPP=Y STATIC=Y SUITES=FV3_GFS_2017
CCPP=Y STATIC=Y SUITES=FV3_GFS_2017
REPRO=Y
""

This and NCAR/ccpp-physics#354 should be good to merge after successfully compiling in all configurations suggested by @climbfuji

@climbfuji
Copy link
Collaborator

UFS also compiles with the following options on hera/intel

'CCPP=Y STATIC=Y SUITES=FV3_GFS_2017 32BIT=Y DEBUG=Y'
'32BIT=Y DEBUG=Y'
'' # i.e. no options, IPD PROD

@climbfuji climbfuji merged commit 2124b57 into NCAR:dtc/develop Nov 25, 2019
@climbfuji climbfuji mentioned this pull request Nov 25, 2019
Merged
climbfuji pushed a commit that referenced this pull request Dec 3, 2019
@junwang-noaa
Merge pull request #8 from junwang-noaa/bugfixes
b18739d 
Bugfixes in inline post, netcdf time stamp and gfs physics for coupled system. GFS physics update to reduce the cold bias in lower atmosphere layer. VLAB tickets: #69814 and #69735. fv3atm issue: #4, #5, #6 and #7.
@climbfuji climbfuji mentioned this pull request Dec 10, 2019
Merged
@climbfuji climbfuji mentioned this pull request Dec 20, 2019
Merged
DusanJovic-NOAA pushed a commit to NOAA-EMC/fv3atm that referenced this pull request Jan 10, 2020
@climbfuji @DusanJovic-NOAA
Update EMC dev/emc from NCAR dtc/develop 2019/12/17 (#30)
b1ddd67 
* add new suite definition files for GFSv15p2, GFSv16beta
* update existing suite definition files because of the interstitial code rearrangement (NCAR/ccpp-physics#372)
* clean up CCPP compiler flags, add -Wall for GNU in DEBUG mode
* add satmedmfvifq, shalcnv, sascnvn, Ferrier-Aligo microphysics and dependencies to CCPP prebuild config
* bug fixes for ugwp and noahmp
* move previous-timestep precipitation variables from Tbd to Sfcprop (as recommended by @HelinWei-NOAA, see NCAR/ccpp-physics#319)
* fix compiler warnings about non-existent include directories
* cleanup of old comments in GFS_physics_driver.F90 (see NCAR#4, NCAR#16, and NCAR/ccpp-physics#319
* CCPP annotations in GFS_driver.F90, GFS_radiation_driver.F90, GFS_physics_driver.F90 (comments that describe where code blocks ended up in the CCPP interstitial code)
* capability to coldstart FV3 with GSD physics from RAP/HRRR initial conditions (required for FV3 SAR)
* new suite definition file for coupled model
@DeniseWorthen DeniseWorthen mentioned this pull request Jan 16, 2020
Merged
climbfuji pushed a commit that referenced this pull request Apr 3, 2020
@JiliDong-NOAA
Merge pull request #4 from hafs-community/feature/add_km
4632d7c 
Correction to the GFS physics driver for the add_km feature
climbfuji pushed a commit that referenced this pull request Jul 15, 2020
@panll
Merge pull request #4 from NCAR/dtc/develop
34337e3 
update
SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Sep 9, 2021
@tanyasmirnova
Merge pull request #4 from climbfuji/tanya_gsl_dev_11aug21_lake_dom
52b38b8 
Revert change to .gitmodules and update submodule pointer for ccpp-physics
SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Jan 7, 2022
@DeniseWorthen
Merge pull request #4 from NOAA-EMC/develop
1067e95 
merge to latest develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climbfuji climbfuji climbfuji approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantfirl @climbfuji