-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abstracting plotting #278
abstracting plotting #278
Conversation
Hello @K20shores. Just one thing : However In I've reviewed all the other files changed in the PR, looks good to me! |
Looks good to me! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 79.90% 81.91% +2.01%
==========================================
Files 12 13 +1
Lines 821 846 +25
==========================================
+ Hits 656 693 +37
+ Misses 165 153 -12 ☔ View full report in Codecov by Sentry. |
@@ -64,12 +57,12 @@ def __init__(self, df, args): | |||
- output_format : str, optional | |||
Format of the output file, either 'csv' or 'netcdf'. Defaults to 'csv'. | |||
""" | |||
self.df = df | |||
self.df = df.copy(deep=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there reason for a Deep copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, without the deep copy, the changes made on the dataframe inside this class are reflected elsewhere, and that's not what we want
Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just have a minor suggestion
When checking out differences in TS1, I noticed that plotting no longer worked after we (correctly) added data headers in #273
This PR