Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUSICA Tutorial Chapter 2 #141

Merged
merged 23 commits into from
Jun 27, 2024
Merged

MUSICA Tutorial Chapter 2 #141

merged 23 commits into from
Jun 27, 2024

Conversation

dwfncar
Copy link
Contributor

@dwfncar dwfncar commented Jun 5, 2024

Tutorial Chapter 2. Initial PR for comments.

@dwfncar dwfncar requested review from K20shores and boulderdaze June 5, 2024 22:03
@dwfncar dwfncar changed the title Tutorial Chapter 2 MUSICA Tutorial Chapter 2 Jun 5, 2024
@dwfncar dwfncar linked an issue Jun 5, 2024 that may be closed by this pull request
@dwfncar dwfncar marked this pull request as draft June 6, 2024 15:08
@dwfncar dwfncar requested review from boulderdaze and K20shores June 18, 2024 15:42
@dwfncar dwfncar marked this pull request as ready for review June 18, 2024 15:43
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you merge main into your branch? I'd like to see the failed tests can pass

Comment on lines +71 to +75

target_link_libraries(test_micm_box_model
PRIVATE
musica::musica-fortran
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might need to add this line:

add_exectuable(test_micm_box_model test_micm_box_model.F90)

unless I'm just missing where this is

@dwfncar dwfncar merged commit 14c7395 into main Jun 27, 2024
58 checks passed
@dwfncar dwfncar deleted the 70-tutorial-ch2 branch June 27, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial Ch 2: Create a box-model that runs MICM for one timestep
4 participants