-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
196 backward euler fortran #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! just a couple minor suggestions
print *, 'A', concentrations((i_cell-1)*NUM_SPECIES+A_index), A | ||
print *, 'B', concentrations((i_cell-1)*NUM_SPECIES+B_index), B | ||
print *, 'C', concentrations((i_cell-1)*NUM_SPECIES+C_index), C | ||
print *, 'D', concentrations((i_cell-1)*NUM_SPECIES+D_index), D | ||
print *, 'E', concentrations((i_cell-1)*NUM_SPECIES+E_index), E | ||
print *, 'F', concentrations((i_cell-1)*NUM_SPECIES+F_index), F | ||
print * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove diagnostic output
num_grid_cells = 3 | ||
micm => micm_t( "configs/analytical", RosenbrockStandardOrder, num_grid_cells, error ) | ||
ASSERT( error%is_success() ) | ||
|
||
call test_multiple_grid_cells( micm, num_grid_cells ) | ||
print *, 'test_multiple_grid_cells standard Rosenbrock' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove diagnostic output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Added fortran API for Backward Euler solvers.
Made time_step and test_accuracy as inputs to test_multiple_grid_cells in test_micm_api.F90.