Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

196 backward euler fortran #210

Merged
merged 12 commits into from
Sep 12, 2024
Merged

196 backward euler fortran #210

merged 12 commits into from
Sep 12, 2024

Conversation

dwfncar
Copy link
Contributor

@dwfncar dwfncar commented Aug 27, 2024

Added fortran API for Backward Euler solvers.
Made time_step and test_accuracy as inputs to test_multiple_grid_cells in test_micm_api.F90.

@dwfncar dwfncar linked an issue Aug 27, 2024 that may be closed by this pull request
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple minor suggestions

Comment on lines 275 to 281
print *, 'A', concentrations((i_cell-1)*NUM_SPECIES+A_index), A
print *, 'B', concentrations((i_cell-1)*NUM_SPECIES+B_index), B
print *, 'C', concentrations((i_cell-1)*NUM_SPECIES+C_index), C
print *, 'D', concentrations((i_cell-1)*NUM_SPECIES+D_index), D
print *, 'E', concentrations((i_cell-1)*NUM_SPECIES+E_index), E
print *, 'F', concentrations((i_cell-1)*NUM_SPECIES+F_index), F
print *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove diagnostic output

num_grid_cells = 3
micm => micm_t( "configs/analytical", RosenbrockStandardOrder, num_grid_cells, error )
ASSERT( error%is_success() )

call test_multiple_grid_cells( micm, num_grid_cells )
print *, 'test_multiple_grid_cells standard Rosenbrock'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove diagnostic output

@dwfncar dwfncar requested a review from mattldawson September 5, 2024 15:38
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@dwfncar dwfncar merged commit a316b0d into main Sep 12, 2024
66 checks passed
@dwfncar dwfncar deleted the 196-backward-euler-fortran branch September 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fortran API Backward Euler Option
5 participants