Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

79 allow updates to custom rate constant parameters and mapping by name #80

Conversation

K20shores
Copy link
Collaborator

@K20shores K20shores commented Mar 29, 2024

Closes #79. #81 was opened to address the remaining work for fortran

@K20shores K20shores linked an issue Mar 29, 2024 that may be closed by this pull request
@K20shores K20shores marked this pull request as ready for review April 2, 2024 14:24
@K20shores K20shores requested a review from mattldawson April 2, 2024 14:24
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! we can figure out the Fortran test failures in a follow-up PR

@mattldawson mattldawson merged commit 19590a7 into main Apr 2, 2024
26 of 34 checks passed
@mattldawson mattldawson deleted the 79-allow-updates-to-custom-rate-constant-parameters-and-mapping-by-name branch April 2, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow updates to custom rate constant parameters and mapping by name
2 participants