Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtc/develop from EMC develop and ufs_public_release 2019/12/16 #16

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 16, 2019

This PR and NCAR/fv3atm#21 update the dtc/develop branch with changes that were originally made for the EMC ufs_public_release branch and with changes from ECM's develop branch:

  • new cmake build system for ufs-weather-model
  • add support for Cheyenne with Intel and GNU to new cmake build
  • add regression tests for suites FV3_GFS_v15p2 and FV3_GFS_v16beta
  • tests/fv3_conf/ccpp_*_run.IN: remove INPUT and RESTART as first step, because CCPP regression test directories are reused when the same job is run twice in CCPP dynamic and static mode

For regression testing, see below.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 16, 2019

Regression testing on hera/intel against DTC baseline (trunk-20191127; this is identical to the EMC baseline with the same date tag, except that updates of the NoahMP and GSD tests are already included): all tests pass, except the newly added CCPP PROD tests rt_136_fv3_ccpp_gfs_v15p2_prod.log and rt_137_fv3_ccpp_gfs_v16beta_prod.log ("missing baseline").

rt_full.log

@climbfuji climbfuji changed the title Update dtc/develop from ufs_public_release 2019/12/16 Update dtc/develop from EMC develop and ufs_public_release 2019/12/16 Dec 16, 2019
@climbfuji
Copy link
Collaborator Author

Regression testing on Cheyenne/GNU using rt_gnu.conf: all tests pass, except the newly added CCPP PROD tests rt_011_fv3_ccpp_gfs_v15p2_prod.log and rt_012_fv3_ccpp_gfs_v16beta_prod.log ("missing baseline").

rt_gnu.log

@climbfuji
Copy link
Collaborator Author

Regression tests on hera/intel using rt_ccpp_hafs.conf (first create, then verify): all tests pass.

rt_ccpp_hafs_create.log
rt_ccpp_hafs_verify.log

@climbfuji
Copy link
Collaborator Author

NEMSCompsetRun test on hera/intel against EMC baseline (trunk-20191127): tests pass except fv3_gfdlmprad_noahmp. This is expected, because the EMC baseline was created before the NoahMP bugfix was made.

NEMSCompsetRun.log

@climbfuji
Copy link
Collaborator Author

Regression tests on hera/intel using rt_ccpp_gsd.conf (first create, then verify): all tests pass.

rt_ccpp_gsd_create.log
rt_ccpp_gsd_verify.log

@climbfuji
Copy link
Collaborator Author

Regression tests on hera/intel using rt_ccpp_caps.conf (first create, then verify): all tests pass.

rt_ccpp_caps_create.log
rt_ccpp_caps_verify.log

@climbfuji
Copy link
Collaborator Author

Regression testing on Cheyenne/Intel using rt_intel.conf: all tests pass, except the newly added CCPP PROD tests rt_011_fv3_ccpp_gfs_v15p2_prod.log and rt_012_fv3_ccpp_gfs_v16beta_prod.log ("missing baseline").

In the first pass, the test fv3_ccpp_gfdlmprad_gwd_repro also failed because of a PBS error. I reran the test and it passed.

rt_intel.log
rt_intel_rerun_fv3_ccpp_gfdlmprad_gwd_repro.log

@climbfuji
Copy link
Collaborator Author

Regression testing on hera/intel using rt.conf (first create, then verify against own baseline): all pass

rt_verify.log
rt_create.log

… because CCPP regression test directories are reused when the same job is run twice in CCPP dynamic and static mode
Copy link

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me. I hope changes to building/running get documented appropriately!

@climbfuji
Copy link
Collaborator Author

OK by me. I hope changes to building/running get documented appropriately!

Thanks. There are no immediate changes to running and building the model. The old compile.sh script still works, and rt.sh can use either of them (this is transparent to the user).

@climbfuji climbfuji merged commit 430976c into NCAR:dtc/develop Dec 17, 2019
climbfuji pushed a commit that referenced this pull request Feb 3, 2020
* add fh00 post control file, add restart output at specified forecast hours, ugwd bug fixes
* update module files to use g2tmpl v1.6.0 and post v8.0.1
* add fh00 post control file in fv3.input for inline post
* update in runduration in atmos
* update RT baseline directory on hera and wcoss
* comment out fv3_wrtGauss_nemsio_c768 on dell
* update grib2 table for g2tmpl 1.6.0
* update post
* comment out print line in FV3
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request May 8, 2020
Bug fixes to 3D diagnostic tendencies (based on NCAR#12)
XiaSun-Atmos pushed a commit to XiaSun-Atmos/ufs-weather-model that referenced this pull request Aug 8, 2020
* add new suite definition files for GFSv15p2, GFSv16beta
* update existing suite definition files because of the interstitial code rearrangement (NCAR/ccpp-physics#372)
* clean up CCPP compiler flags, add -Wall for GNU in DEBUG mode
* add satmedmfvifq, shalcnv, sascnvn, Ferrier-Aligo microphysics and dependencies to CCPP prebuild config
* bug fixes for ugwp and noahmp
* move previous-timestep precipitation variables from Tbd to Sfcprop (as recommended by @HelinWei-NOAA, see NCAR/ccpp-physics#319)
* fix compiler warnings about non-existent include directories
* cleanup of old comments in GFS_physics_driver.F90 (see NCAR#4, NCAR#16, and NCAR/ccpp-physics#319
* CCPP annotations in GFS_driver.F90, GFS_radiation_driver.F90, GFS_physics_driver.F90 (comments that describe where code blocks ended up in the CCPP interstitial code)
* capability to coldstart FV3 with GSD physics from RAP/HRRR initial conditions (required for FV3 SAR)
* new suite definition file for coupled model
@climbfuji climbfuji deleted the update_dtc_develop_from_ufs_public_release_20191216 branch June 26, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants