UFS testing for HWRF Noah and GFDL surface layer #47

grantfirl · 2020-05-14T15:45:16Z

add UFS RTs for the GFS_v15p2 suite with drop-in HWRF LSM and SL components, add HWRF test for C96
namelists in parm should be temporary for testing purposes and can be removed before HWRF physics goes to master
tests in tests/tests should be temporary too
this PR includes tests for operational + HWRF Noah, operational + GFDL surface layer, operational + both HWRF Noah and GFDL surface layer, and my best attempt at the entire HWRF suite; all but the entire HWRF suite should likely be removed before going to master
using HWRF Noah requires use of its table files (VEGPARM.TBL, SOILPARM.TBL, GENPARM.TLB) from WRF as fix files (attached in this PR)
although several namelist options were added, it is important to set:
- lsm = 4 to match the SDF when using HWRF Noah
- sfc_z0_type = X (4 was tested and appears to be what is used in HWRF)
- fhcyc = 0 (likely temporary until this can be tested/checked with surface cycling on)

This supercedes #37

…onents, add HWRF test for C96

grantfirl · 2020-05-18T17:44:14Z

Regression testing log:
rt_full.log

All tests passed except for the new tests, which have MISSING_BASELINE

grantfirl · 2020-05-18T17:45:14Z

Associated PRs:
NCAR/ccpp-physics#452
NCAR/fv3atm#49
#47

grantfirl · 2020-05-18T17:49:43Z

Please see https://drive.google.com/open?id=1MTtmb-w8zhq_I_LHADgf03bbrAWQ8uCP for quick/dirty ncview plots displaying surface quantities between the operational GFS suite (control), control + HWRF LSM, control + HWRF SL (surface layer), HWRF complete. All suites look reasonable to me (be careful not to interpret too much since all plots have different ranges/colorbars!!!). An issue was noted with 2m diagnostics that can be addressed in a followup PR.

climbfuji · 2020-05-27T22:57:03Z

These PRs look ok to me, noting the follow-up changes that need to be made and the temporary nature of several of the files in parm, tests/fv3_conv, tests/tests, FV3/ccpp/suites.

@grantfirl
(1) I don't see the attached files (VEGPARM.TBL, SOILPARM.TBL, GENPARM.TLB) in this PR. You can also stage them on hera or cheyenne for me.
(2) I would like to run tests on Cheyenne with Intel and GNU as well. I will send you updates for rt_intel.conf and rt_gnu.conf
(3) I will create new baselines on both Hera and Cheyenne afterwards. Once this is done, you need to update the date tag in rt.sh and we rerun all tests (to make sure all pass).

climbfuji · 2020-05-28T02:36:29Z

@grantfirl I just realized that your PRs are not up to date with the head of dtc/hwrf-physics. I can create additional PRs that pull your PRs into the head of dtc/hwrf-physics for each of the repositories, or you can do that and update your PRs. If you do so, please also:

in fv3atm, change .gitmodules to point ccpp-physics to your fork and branch, and commit together with the submodule pointer update for ccpp-physics
in ufs-weather-model, change .gitmodules to point fv3atm to your fork and branch, and commit together with the submodule pointer update for fv3atm

Let me know what you prefer, please.

grantfirl · 2020-05-28T15:22:05Z

@grantfirl I just realized that your PRs are not up to date with the head of dtc/hwrf-physics. I can create additional PRs that pull your PRs into the head of dtc/hwrf-physics for each of the repositories, or you can do that and update your PRs. If you do so, please also:

in fv3atm, change .gitmodules to point ccpp-physics to your fork and branch, and commit together with the submodule pointer update for ccpp-physics

in ufs-weather-model, change .gitmodules to point fv3atm to your fork and branch, and commit together with the submodule pointer update for fv3atm

Let me know what you prefer, please.

I will do so.

grantfirl · 2020-05-28T21:29:32Z

Here are the data files for HWRF Noah LSM. When I was poking around some FV3_input directories, I thought that I may have already seen files with these names. I'm not sure if they're identical to the attached ones or not.
HWRF_NOAH_data.zip

grantfirl · 2020-05-28T21:32:33Z

@climbfuji I just ran the rt.conf tests for a some code changes that were going to be part of a followup PR (also used code from dtc/hwrf-physics that was from May 4). Rather than doing a followup PR, since the regression tests need to be rerun, should I just combine what was going to be the followup changes into this PR? Hopefully, it will simplify regression testing.

climbfuji · 2020-05-28T21:33:54Z

@climbfuji I just ran the rt.conf tests for a some code changes that were going to be part of a followup PR (also used code from dtc/hwrf-physics that was from May 4). Rather than doing a followup PR, since the regression tests need to be rerun, should I just combine what was going to be the followup changes into this PR? Hopefully, it will simplify regression testing.

Sure, I haven't started running the tests yet. If you do update the ccpp-physics PR, please make sure to also update the submodule pointer in fv3atm (so that it doesn't say "new commits" anymore).

climbfuji · 2020-05-28T21:38:00Z

HWRF_NOAH_data.zip

For each of these files, a version exists in the FV3_input_data directory of the regression test baseline. However, they are all different from the ones in the zip file. What is your suggested name for the additional input data? Should it go into FV3_input_data_hafs or into a new directory FV3_input_data_XYZ ?

grantfirl · 2020-05-28T21:49:31Z

HWRF_NOAH_data.zip

For each of these files, a version exists in the FV3_input_data directory of the regression test baseline. However, they are all different from the ones in the zip file. What is your suggested name for the additional input data? Should it go into FV3_input_data_hafs or into a new directory FV3_input_data_XYZ ?

Since these files were taken directly from WRFv4, maybe prepend or append WRFv4? IMO, they can go in FV3_input_data_hafs.

grantfirl · 2020-05-28T22:12:58Z

OK, @climbfuji, all PRs have been updated to have the latest dtc/hwrf-physics, the .gitmodules have been changed, and I merged in the followup ccpp-physics changes. This should be ready to test. Should I go ahead and kick off the rt.conf test again on Hera for this?

climbfuji · 2020-05-28T22:19:08Z

OK, @climbfuji, all PRs have been updated to have the latest dtc/hwrf-physics, the .gitmodules have been changed, and I merged in the followup ccpp-physics changes. This should be ready to test. Should I go ahead and kick off the rt.conf test again on Hera for this?

Thanks, @grantfirl. Since I need to create a new baseline on hera as well, you can also leave those tests to me. I'll put the new TBL files in the FV3_input_data_hafs directory.

climbfuji · 2020-05-28T22:23:25Z

@grantfirl I don't see the fv3atm submodule pointer update in this PR.

grantfirl · 2020-05-28T22:31:32Z

OK, @climbfuji, all PRs have been updated to have the latest dtc/hwrf-physics, the .gitmodules have been changed, and I merged in the followup ccpp-physics changes. This should be ready to test. Should I go ahead and kick off the rt.conf test again on Hera for this?

Thanks, @grantfirl. Since I need to create a new baseline on hera as well, you can also leave those tests to me. I'll put the new TBL files in the FV3_input_data_hafs directory.

OK, great. I will at least compile it there. I haven't done that since updating to dtc/hwrf-physics.

grantfirl · 2020-05-28T23:04:11Z

It compiles OK, but now I'm getting the following runtime error:

fv3.exe: libccppphys.so.3: cannot open shared object file: No such file or directory
86: ERROR: A problem occured loading GFS_time_vary_pre_init from ccppphys
86: ERROR: In initializing the CCPP suite
86:
86: FATAL from PE 86: atmosphere_dynamics: error in ccpp_init:

climbfuji · 2020-05-28T23:08:55Z

Hmm. We don't have the dynamic CCPP build anymore. This is weird. Did you try to run the job manually in some "old" run directory, or kick off the regression tests?

climbfuji · 2020-05-28T23:12:07Z

It compiles fine with both Intel and GNU in PROD mode, and I also tried with GNU in DEBUG mode. Will kick off the regression tests and see if I get the same error as you.

grantfirl · 2020-05-28T23:12:58Z

I copied rt.conf and deleted everything except compiling with the new HWRF suites and running. I have no idea what happened.

climbfuji · 2020-05-28T23:20:42Z

It seems to work fine for me on Cheyenne with both Intel and GNU, will test hera later tonight.

Update: all looking good. I guess that when you pulled in the updates from dtc/hwrf-physics, you didn't check if the other submodules need to be updated to new hashes. Do you see "new commits" for any of the submodules (in ufs-weather-model or fv3atm)?

Will send you a PR for ufs-weather-model and start uploading the regression testing results to this PR in a bit.

climbfuji · 2020-05-29T15:17:06Z

Regression testing on cheyenne.gnu:

run regression tests in tests/rt_gnu.conf against existing baseline: all existing tests pass, all new tests fail (as expected; missing baseline)

rt_cheyenne_gnu_verify_against_existing_baseline.log
rt_cheyenne_gnu_verify_against_existing_baseline_fail_test.log

create new baseline using tests/rt_gnu.conf, including the additional tables in FV3_input_data_hafs: all tests pass

rt_cheyenne_gnu_create_new_baseline.log

copy this new, temporary baseline to the final location (new date tag 20200528)
verify against this baseline using tests/rt_gnu.conf: all tests pass

rt_cheyenne_gnu_verify_against_new_baseline.log

climbfuji · 2020-05-29T15:19:46Z

Regression testing on cheyenne.intel:

run regression tests in tests/rt_intel.conf against existing baseline: all existing tests pass, except for the known issues (see 4.), all new tests fail (as expected; missing baseline)

rt_cheyenne_intel_verify_against_existing_baseline.log
rt_cheyenne_intel_verify_against_existing_baseline_fail_test.log

create new baseline using tests/rt_intel.conf, including the additional tables in FV3_input_data_hafs: all tests pass

rt_cheyenne_intel_create_new_baseline.log

copy this new, temporary baseline to the final location (new date tag 20200528)
verify against this baseline using tests/rt_intel.conf: all tests pass, except the known issues:

rt_cheyenne_intel_verify_against_new_baseline.log
rt_cheyenne_intel_verify_against_new_baseline_fail_test.log

heinzell@cheyenne1:/glade/work/heinzell/fv3/ufs-weather-model/ufs-weather-model-dtc-hwrf-physics-20200527-add-hwrf-noahlsm-and-gfdl-sfclay/intel/tests> grep -e FAIL log_cheyenne.intel/*
log_cheyenne.intel/rt_029_fv3_ccpp_regional_c768_FA_prod.log:Test 029 fv3_ccpp_regional_c768_FA FAIL
log_cheyenne.intel/rt_030_fv3_ccpp_regional_c768_HWRF_PBL_prod.log:Test 030 fv3_ccpp_regional_c768_HWRF_PBL FAIL
log_cheyenne.intel/rt_031_fv3_ccpp_regional_c768_FA_HWRF_RRTMG_prod.log:Test 031 fv3_ccpp_regional_c768_FA_HWRF_RRTMG FAIL
log_cheyenne.intel/rt_043_fv3_ccpp_regional_c768_FA_repro.log:Test 043 fv3_ccpp_regional_c768_FA FAIL
log_cheyenne.intel/rt_044_fv3_ccpp_regional_c768_HWRF_PBL_repro.log:Test 044 fv3_ccpp_regional_c768_HWRF_PBL FAIL
log_cheyenne.intel/rt_045_fv3_ccpp_regional_c768_FA_HWRF_RRTMG_repro.log:Test 045 fv3_ccpp_regional_c768_FA_HWRF_RRTMG FAIL

climbfuji · 2020-05-29T15:21:58Z

Regression testing on hera.intel:

run regression tests in tests/rt.conf against existing baseline: all existing tests pass, all new tests fail (as expected; missing baseline)

rt_hera_intel_verify_against_existing_baseline.log
rt_hera_intel_verify_against_existing_baseline_fail_test.log

create new baseline using tests/rt.conf, including the additional tables in FV3_input_data_hafs: all tests pass

rt_hera_intel_create_new_baseline.log

copy this new, temporary baseline to the final location (new date tag 20200528)
verify against this baseline using tests/rt.conf: all tests passed

rt_hera_intel_verify_against_new_baseline.log

Updates for hwrf_sfc_PR from Dom

…itmodules

climbfuji

Changes look good, all tests passed, hash for fv3atm is correct.

grantfirl · 2020-05-29T16:14:22Z

Thanks very much @climbfuji for guiding me through the testing/review/merge process. You're a true pro as always!

climbfuji · 2020-05-29T16:17:14Z

Thanks for these code changes - all clean and straightforward!

mzhangw · 2020-05-29T16:18:25Z

Just to confirm, it looks like that dtc/hwrf-physics is ready for HWRF physics suite test?

…

On May 29, 2020, at 10:14 AM, grantfirl ***@***.***> wrote: Thanks very much @climbfuji <https://github.com/climbfuji> for guiding me through the testing/review/merge process. You're a true pro as always! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2QIYKB7P5DSD3FEV73RT7NOZANCNFSM4NAZXGAQ>.

grantfirl · 2020-05-29T16:23:38Z

@mzhangw Yes.

Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>

@SMoorthi-emc

* Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) * point MOM6 to new branch which corresponding to GFDL 20201022 commit * modify fms_files.cmake and mom6_files.cmake to reflect changes in MOM6 code as this version of MOM6 contains some file deletion, new files being added and renaming of files * manually set MOM6 parameters in order to retain origonal results for 0.25x0.25 resolution * update MOM6 to include Bugfix for mom6solo to be built * modify compile.sh to allow mom6solo compiling * modify MOM_input_template for all resolutions based on GFDL MOM6-example main branch update on 20201022 * change executable permissions for CMakeLists.txt * chmod 644 to 6 files Dom pointed out * chmod for CMakeLists.txt and tests/compile.sh * change baseline directpory to 20201202 in rt.sh * Update CICE, Move regression test input outside baseline directory (ufs-community#270) *Updates CICE to most recent develop branch of NOAA-EMC * Sets n_aero (number of aerosols) in ice_in_template to 0. * removes trailing whitespace from ice_in * moves regression test input outside baseline directory (ufs-weather PR ufs-community#312) Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> * Updates to build for JEDI linking/control, add wcoss2 (ufs-community#295) * Build on wcoss2 (acorn) * Use -march=core-avx2 instead of -xCORE-AVX2 on wcoss2 * Updates to build for JEDI linking/control * Removed unnecessary include files and INLINE POST setting * Updated to address PR suggestions. * Add rt_acorn.conf. Change /lfs/h2 to /lfs/h1. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * regression test results * Updated .gitmodules and removed extraneous file * Fixed .gitmodules and updated pointer for FV3 * Updated pointer to NEMS repo Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Final-final GFS v16 updates / restart reproducibility bugfixes (ufs-community#325) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Add GFS v16 beta restart test, update stochastics test * Update regression test baseline date tag to 20201214; skip-ci * tests/rt.conf: bugfix, add missing 'fv3' to new stochy tests; skip-ci * Regression test logs for gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Run GFS v16beta tests also on wcoss; regression test logs for wcoss; skip-ci * Regression test logs for cheyenne.intel and cheyenne.gnu * Revert change to .gitmodules and update submodule pointer for fv3atm * Add optional bulk flux calculation in ufs-datm (ufs-community#266) * Update NEMS DATM and CMEPS to allow the optional bulk flux formulation; add two tests using the option * Update top level CMakeList.txt to have compile flags for MOM6 and CICE6 identical for ufs-cpld and ufs-datm * Add optional configuration variable to nems.configure to specify the directory where CMEPS will write restarts * Adds cheyenne tasking variables to default_vars and sets WW3_COMP to cheyenne for platform cheyenne.intel *NOTE: Baselines develop-20201215 exist on all platforms, regression tests were run against exactly that baseline on all systems except cheyenne.intel. On cheyenne.intel the tests were run against 20201214, and this baseline is identical to 20201215 (as per "diff -r develop-20201214 develop-20201215"). Co-authors: @DusanJovic-NOAA @aerorahul @JessicaMeixner-NOAA skip-ci * Add 2 new tests for DATM-MOM6-CICE6 application (ufs-community#332) * Add the following 2 tests: datm_restart_cfsr, datm_debug_cfsr * Add wcoss_dell_p3.log. * Add Hera log, Orion log, wcoss_dell_p3 log. * RRTMGP and Thompson MP coupling (ufs-community#323) * Feature branch with RRTMGP and Thompson MP * Updated FV3/ccpp-physics. Added namelist and configuration for RRTMGP RTs using GSD physics. * Updated FV3 * Update physics in FV3 * Updated baselines in rt.sh * Updated RT logs. Updated FV3 physics submodule pointer. * Updated FV3 hash and .gitmodules * Regression test log for PR ufs-community#323 for jet.intel (ufs-community#336) * Update modules with hpc-stack v1.1.0 (ufs-community#319) * Update modules with hpc-stack v1.1.0 * Minor bug fixes to CCPP UGWP Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Replace old regional SDF with FV3_GFS_v15_thompson_mynn (ufs-community#333) * Replace old FV3_GFS_2017_gfdlmp_regional SDF for regional tests with FV3_GFS_v15_thompson_mynn. * Final path to IC's and new results. Also, input.nml updated. * Update RegressionTests_wcoss_dell_p3.log * Update RegressionTests_wcoss_cray.log * Update RegressionTests_hera.intel.log * Update RegressionTests_jet.intel.log * Update RegressionTests_orion.intel.log * Update RegressionTests_cheyenne* logs. * Update RegressionTests_hera.gnu.log * Feature/ww3update (ufs-community#334) This updates the WW3 submodule pointer to point to the top of the WW3 develop branch. The path to WW3 inputs is changed to input-data-20201201/WW3_input_data_20201207/ * Remove IPD (step 1) (ufs-community#331) Make CCPP=Y the default in tests/compile.sh. Remove CCPP=Y from tests/rt*.conf and adjust formatting. Update submodule pointer for MOM6 to include PR ufs-community#341 ("Update MOM6 to GFDL's 20201218 commit") Add modulefiles/wcoss_cray/fv3_debug (identical to modulefiles/wcoss_cray/fv3) Fix broken utest (see ufs-community#348) * Update the format of rt.conf (ufs-community#349) Update the format of MACHINES column in rt.conf (and other .conf files). This column can be either empty, which means a test will run on all supported machines, or start with - or + sign to exclude or include specified machines explicitly. * Add checkpoint restarts for ufs-cpld (ufs-community#342) * Adds 3 checkpoint restart tests for the ufs-cpld model * Drops the existing c92mx025 restart test * Adds cheyenne.intel as tested configuration for ufs-cpld and ufs-datm * Fixes instances of srf_data* in various fv3_conf files * add frac grid input, update and add additional cpld tests (ufs-community#354) * Updates FV3_input_frac to add both benchmark dates and L127 files * Adds additional tests and restart tests for coupled model * Sets all cpld tests to use frac grid input by default * Removes all instances of USE_LA_LI2016=True except for benchmark+wave configurations * Remove unnecessary SIMD instruction sets for Jet, first round of cleanup in rt.conf, initialize cld_amt to zero for regional runs (dycore) (ufs-community#353) * Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5 * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Remove tests/rt_acorn.conf and run GFS v15p2 and GFS v16beta DEBUG tests on all platforms * Implementation of CCPP timestep_init and timestep_final phases (ufs-community#337) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update submodule pointer for fv3atm; skip-ci * Don't try to compile all suites in DEBUG mode on cheyenne.intel, weird bug on compute nodes; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_cray; skip-ci * Regression test logs for cheyenne.gnu, cheyenne.intel, gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_dell_p3; skip-ci * Regression test logs for wcoss_cray and wcoss_dell_p3 * Revert change to .gitmodules and update submodule pointer for fv3atm * Update CMEPS (ufs-community#345) * Update CMEPS for recent changes, including addition of new run "post" run phases to eliminate redundant mapping, multiple ice sheet capability and ocn->land ice dynamic mapping * Add a new test fv3_gfs_v16_RRTMGP_c192L127 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Remove IPD steps 3 and 5 (ufs-community#357) Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5; skip-ci * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Update usage in rt.sh, add modulefiles/jet.intel/fv3_debug; skip-ci * CCPP is default in cmake build * Add debug modulefiles for linux.gnu and macosx.gnu * Update submodule pointer for fv3atm * Change logic in CMakeLists.txt and tests/compile.sh so that 32BIT=ON automatically sets DYN32=ON; skip-ci * Move logic to set DYN32 - depending on 32BIT setting - to fv3atm * Remove -DCCPP=ON from tests/compile.sh; update submodule pointer for fv3atm; skip-ci * point fv3 to EMC develop branch (ufs-community#377) * update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps (ufs-community#378) * update CMEPS, fix character length error for gnu compile * add Dusan's fix for rt_utils.sh * update cpl gfsv16 tests, replace seaice_newland.grb with global_slmask.t1534.3072.1536.grb, recover input.mom6.nml.IN, update input directory, update global thread and decomp tests, update fdiag for global control * point to Dustins rrtmgp fix branch * update input directory Co-authored-by: denise.worthen <Denise.Worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (ufs-community#386) * Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch * RUC ice for gsl/develop (replaces NCAR#47) (NCAR#49)Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm * Update gsl/develop from develop 2020/12/08 (NCAR#50) * Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Land stochastic perturbations (NCAR#57) * dycore options to add zero-gradient BC to reconstruct interface u/v and change dz_min as input (ufs-community#369) * Update fv3atm * update ccpp control test forecast length to 24h * remove rename command * Add CI related changes * Update RT logs * Update RT log files * Add the gaea RT log file * Update the point of fv3atm * Update fv3atm Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> * MOM6 bugfixes, GFDL update, update CDMBGWD settings; fix for restart reproducibility (without waves) when USE_LA_LI2016=True, sign error on fprec passed to ocean, GFDL update, resolution dependent cdmbgwd settings (ufs-community#379) * implements two MOM6 bugfixes in the NUOPC MOM6 cap to allow restart reproducibility when USE_LA_LI2016=True and to change the sign of the latent heat flux associated with frozen precipitation (fprec) exported to MOM6 * updates MOM6 to include the GFDL 20210120 main branch which contains EMC's wave coupling code, alone with some minor code standardization and documentation * updates the cdmbgwd namelist settings for FV3 standalone tests at C96 and implements resolution dependent values for ufs-cpld tests Co-authored-by: Ali <ali.abdolali@noaa.gov> * Remove legacy gnumake build from fv3atm and NEMS, remove legacy Python 2.7 support, rename v16beta to v16 and RT updates (ufs-community#384) * Update .gitmodules and submodule pointers for fv3atm and NEMS * Remove Python 2.7 support from top-level CMakeLists.txt * Reduce forecast length of test fv3_ccpp_gfs_v16_RRTMGP_c192L127 from 24h to 12h * Rename v16beta to v16 everywhere except the public release documentation * Bugfixes and missing changes * Remove 'export CCPP_LIB_DIR=ccpp/lib' from all regression tests * Update regression test baseline date tag to 20210128; skip-ci * Update ecflow-python environment on cheyenne and jet; skip-ci * Update CMEPS for HAFS integration; add datm and coupled-model tests on Gaea (ufs-community#401) * Add HAFS support in NOAA-EMC/CMEPS * Add coupled and datm tests for Gaea.intel Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Bin Li <Bin.Li@gaea13.ncrc.gov> * Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization (remove IPD step 2) (ufs-community#407) * Regression test logs for all tier=1 platforms * updates FMS to 2020.04.01 (ufs-community#392) * updates FMS to 2020.04.01 * fixes fms_files.cmake * removes extra horiz_interp * Workaround for FMS 2020.04.01 for Cheyenne with GNU 9.1.0, incl. regression test log Co-authored-by: Mikyung Lee <mlee@Orion-login-1.HPC.MsState.Edu> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * add optional mesh in MOM6; add dz_min and min_seaice as configurable variables for coupled model (ufs-community#399) *Implements an optional setting in the cpld and datm nems.configure files to specify whether the MOM6 cap should use a mesh or a grid *Adds configurable settings for min_seaice to gfs_physics_nml and dz_min to fv_core_nml. * UGWP v0 v1 combined (ufs-community#396) - combines the changes in PRs ufs-community#360 and ufs-community#382 - adds three regression tests `fv3_ccpp_gfsv16_ugwpv1 `, `fv3_ccpp_gfsv16_ugwpv1_warmstart` and `fv3_ccpp_gfsv16_ugwpv1_debug` - contains updates and bugfixes for `nc_compare.py` and the CI tests from @MinsukJi-NOAA - update Python3 environment on jet.intel, gaea.intel, cheyenne.{intel,gnu} - turn off (again) test `fv3_ccpp_decomp` on jet.intel, this test didn't work in the past, but recently it "passed", because the error checking with `nc_compare.py` failed silently and we didn't notice it Co-authored-by: valery.yudin <valery.yudin@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> * Update regression tests from GFSv15+Thompson to GFSv16+Thompson, include "Add one regional regression test in DEBUG mode. (ufs-community#419)" (ufs-community#421) * Add one regional regression test in DEBUG mode. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update regression tests from GFSv15+Thompson to GFSv16+Thompson * Combine several COMPILE lines in tests/rt.conf and tests/rt_gnu.conf * Regression test log for cheyenne.{gnu,intel},gaea.intel, hera.gnu, jet.intel,hera.intel,orion.intel;wcoss_cray and wcoss_dell_p3; Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: jiandewang <jiande.wang@noaa.gov> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Mark Potts <33099090+mark-a-potts@users.noreply.github.com> Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: dustinswales <dustin.swales@noaa.gov> Co-authored-by: Kyle Gerheiser <3209794+kgerheiser@users.noreply.github.com> Co-authored-by: RatkoVasic-NOAA <37597874+RatkoVasic-NOAA@users.noreply.github.com> Co-authored-by: Ali.Abdolali <37336972+aliabdolali@users.noreply.github.com> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> Co-authored-by: XiaqiongZhou-NOAA <48254930+XiaqiongZhou-NOAA@users.noreply.github.com> Co-authored-by: Ali <ali.abdolali@noaa.gov> Co-authored-by: Bin Li <Bin.Li@gaea13.ncrc.gov> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: valery.yudin <valery.yudin@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>

add UFS RTs for the GFS_v15p2 suite with drop-in HWRF LSM and SL comp…

69a9e0b

…onents, add HWRF test for C96

grantfirl requested review from climbfuji and llpcarson as code owners May 14, 2020 15:45

grantfirl mentioned this pull request May 14, 2020

Add HWRF NOAH LSM test #37

Closed

grantfirl added 7 commits May 14, 2020 11:06

change nwat to 4 in HWRF suite namelist

95613c9

turn do_sat_adj off for HWRF suite that uses FA MP

0f03658

set fhcyc to zero when using WRFv4 Noah LSM

ba5d6ce

add DATAMPNEW_DATA* to fix files copied in ccpp_HAFS_v0_hwrf_run.IN

ef5fafc

change a few namelist settings in HAFS_v0_hwrf test

1ade57b

remove write_do_post from hwrf global test

1f3ceb6

add new tests to rt.conf

ce08dcc

grantfirl mentioned this pull request May 18, 2020

addition of HWRF Noah LSM and GFDL surface layer NCAR/ccpp-physics#452

Merged

grantfirl changed the title ~~add UFS RTs for the GFS_v15p2 suite with drop-in HWRF LSM and SL comp…~~ UFS testing for HWRF Noah and GFDL surface layer May 18, 2020

grantfirl mentioned this pull request May 18, 2020

support HWRF Noah LSM and GFDL surface layer NCAR/fv3atm#49

Merged

Merge branch 'dtc/hwrf-physics' into hwrf_sfc_PR

a9b6392

change fv3atm to point to grantfirl fork and hwrf_sfc_PR branch

e6de09e

update submodule pointer for FV3

f4f4faa

Update of regression tests for new LSM and SFCLAY physics

e070b94

grantfirl added 2 commits May 29, 2020 09:22

Merge pull request #1 from climbfuji/hwrf_sfc_PR_dom_for_grant

66f30e6

Updates for hwrf_sfc_PR from Dom

update submodule pointer for FV3 after merge and revert changes to .g…

4bb262c

…itmodules

climbfuji approved these changes May 29, 2020

View reviewed changes

grantfirl merged commit fbbba9b into NCAR:dtc/hwrf-physics May 29, 2020

grantfirl mentioned this pull request Oct 19, 2020

Add/update HWRF physics NCAR/ccpp-physics#509

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UFS testing for HWRF Noah and GFDL surface layer #47

UFS testing for HWRF Noah and GFDL surface layer #47

grantfirl commented May 14, 2020 •

edited

Loading

grantfirl commented May 18, 2020

grantfirl commented May 18, 2020

grantfirl commented May 18, 2020 •

edited

Loading

climbfuji commented May 27, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020 •

edited

Loading

climbfuji commented May 29, 2020 •

edited

Loading

climbfuji commented May 29, 2020 •

edited

Loading

climbfuji commented May 29, 2020 •

edited

Loading

climbfuji left a comment

grantfirl commented May 29, 2020

climbfuji commented May 29, 2020

mzhangw commented May 29, 2020 via email

grantfirl commented May 29, 2020

UFS testing for HWRF Noah and GFDL surface layer #47

UFS testing for HWRF Noah and GFDL surface layer #47

Conversation

grantfirl commented May 14, 2020 • edited Loading

grantfirl commented May 18, 2020

grantfirl commented May 18, 2020

grantfirl commented May 18, 2020 • edited Loading

climbfuji commented May 27, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020

climbfuji commented May 28, 2020

grantfirl commented May 28, 2020

climbfuji commented May 28, 2020 • edited Loading

climbfuji commented May 29, 2020 • edited Loading

climbfuji commented May 29, 2020 • edited Loading

climbfuji commented May 29, 2020 • edited Loading

climbfuji left a comment

Choose a reason for hiding this comment

grantfirl commented May 29, 2020

climbfuji commented May 29, 2020

mzhangw commented May 29, 2020 via email

grantfirl commented May 29, 2020

grantfirl commented May 14, 2020 •

edited

Loading

grantfirl commented May 18, 2020 •

edited

Loading

climbfuji commented May 28, 2020 •

edited

Loading

climbfuji commented May 29, 2020 •

edited

Loading

climbfuji commented May 29, 2020 •

edited

Loading

climbfuji commented May 29, 2020 •

edited

Loading