Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cf.Field.__getitem__ performance by not re-calculating axis cyclicity #745

Merged
merged 3 commits into from
Mar 23, 2024
Merged

Improve cf.Field.__getitem__ performance by not re-calculating axis cyclicity #745

merged 3 commits into from
Mar 23, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #744

@davidhassell davidhassell added the performance Relating to speed and memory performance label Mar 22, 2024
sadielbartholomew
sadielbartholomew approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, and well-motivated. I've raised some minor comments but please merge once you've considered those.

cf/mixin/fielddomain.py Show resolved Hide resolved
cf/mixin/fielddomain.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
cf/field.py Outdated Show resolved Hide resolved
davidhassell and others added 2 commits March 23, 2024 18:50
@davidhassell @sadielbartholomew
Typos
ade8003 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell @sadielbartholomew
Replace loop with lisyt comprehension
f696627 
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell davidhassell merged commit c02a935 into NCAS-CMS:main Mar 23, 2024
@davidhassell davidhassell deleted the getitem-cyclic branch March 23, 2024 19:11
@sadielbartholomew sadielbartholomew mentioned this pull request Apr 5, 2024
Closed
@davidhassell davidhassell added this to the 3.16.2 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
performance Relating to speed and memory performance
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.

Improve cf.Field.__getitem__ performance by not re-calculating axis cyclicity
2 participants
@davidhassell @sadielbartholomew