netcdfread: safer version handling for Conventions property
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
changed the title
Conventions property version handling by netcdfreadnetcdfread: more robust version handling for Conventions property
sadielbartholomew
changed the title
netcdfread: more robust version handling for Conventions propertynetcdfread: safer version handling for Conventions property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #295,
close #297,close #298, close #301.Waiting on some clarifications to https://github.com/orgs/cf-convention/discussions/321 and to #298 before updating and converting from draft form ready for review.https://github.com/orgs/cf-convention/discussions/321 has confirmed that we don't have to worry about a '-draft' possibility in the
Conventionsattribute value, so #297 is a non-issue I have closed. I will now update the PR accordingly to revert anything related to that and open it for review.