Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fly to coordinates in Cesium map #2246

Closed
iannesbitt opened this issue Jan 17, 2024 · 4 comments · Fixed by #2258
Closed

Fly to coordinates in Cesium map #2246

iannesbitt opened this issue Jan 17, 2024 · 4 comments · Fixed by #2258
Assignees
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center cesium DRP Issues related to the Defense Resiliency Platform enhancement good first issue A good place to start contributing to MetacatUI! pdg Permafrost Discovery Gateway Requested by: Hosted repo Features requested by a DataONE hosted repository
Milestone

Comments

@iannesbitt
Copy link
Contributor

Describe the feature you'd like
DRP team members have requested a way to fly to specific coordinates in the Cesium map. This could exist as a button that reveals a lat, lon text entry field (or two separate fields), which is then used to change the map focus location in a fly to manner similar to that of the behavior after pressing the Home button.

Is your feature request related to a problem? Please describe.
Researchers may be interested in a specific area of the map, which may be easiest to find with a copy/paste of coordinates. This would help researchers and other users zoom to areas of interest quickly.

Additional context
n/a

@iannesbitt iannesbitt added enhancement Requested by: Hosted repo Features requested by a DataONE hosted repository cesium DRP Issues related to the Defense Resiliency Platform labels Jan 17, 2024
@iannesbitt iannesbitt self-assigned this Jan 17, 2024
@robyngit
Copy link
Member

I think this would be one of the more straight forward features to implement. Here are some pointers:

  • The Map Model already has a "zoomTo" method that this widget could call when the coordinates are entered into the entry field
  • We could potentially make use of the GeoPoint model to validate the inputted coordinates.
  • The widget should be its own independent view that interacts with the Map Model (e.g. see the ToolbarView)
  • The MapView should do the work of creating an instance of this widget and inserting it into the map interface.
  • We should design this feature with Include interface for searching for a place name or address in Cesium #1796 in mind. For example, the widget we build here could eventually be extended to navigate to not only specific coordinates, but also place names or addresses.

@robyngit robyngit added good first issue A good place to start contributing to MetacatUI! pdg Permafrost Discovery Gateway labels Jan 17, 2024
@iannesbitt
Copy link
Contributor Author

Thanks Robyn! I agree that it would be good to include place names as part of the search functionality. I will take a look at this when I have the opportunity.

@ianguerin ianguerin self-assigned this Jan 31, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 1, 2024
@ianguerin
Copy link
Collaborator

Here's a demo of what I have built so far: https://drive.google.com/file/d/1Sukzcv3BjcxH3Pi2fNHLd1g2Oii7LNu7/view?usp=drive_link

I'm working on some unit tests now, but figured I'd share this in case it doesn't match expectations

ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 1, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 1, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 1, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 1, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 1, 2024
@robyngit
Copy link
Member

robyngit commented Feb 1, 2024

Looks great @ianguerin! @iannesbitt any comments from the DRP perspective?

@robyngit robyngit added arctic data center ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) labels Feb 1, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 2, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 2, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 2, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 2, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 5, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 6, 2024
@ianguerin ianguerin moved this to In review in Visualization/Frontend Feb 6, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 6, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 6, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 7, 2024
@robyngit robyngit added this to the 2.28.0 milestone Feb 8, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 8, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 8, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Feb 12, 2024
robyngit added a commit that referenced this issue Feb 15, 2024
Feature #2246- view finder feature to fly to user-specified latitude, longitude pair
@github-project-automation github-project-automation bot moved this from In review to Done in Visualization/Frontend Feb 15, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center cesium DRP Issues related to the Defense Resiliency Platform enhancement good first issue A good place to start contributing to MetacatUI! pdg Permafrost Discovery Gateway Requested by: Hosted repo Features requested by a DataONE hosted repository
3 participants