Create child views managing list of Predictions #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianguerin
changed the base branch from
develop
to
feature-1796-places-autocomplete
ianguerin
force-pushed
the
feature-1796-pr-3
branch
13 times, most recently
from
bbd347c
to
49ea0c5
Compare
yvonnesjy
reviewed
Mar 8, 2024
| @@ -0,0 +1,6 @@ | |||
| <div class="<%= classNames.content %> <% if(isFocused) { %>viewfinder-prediction__focused<% } %>"> | |||
| <i class="icon-map-marker"></i> | |||
| <div class="viewfinder-prediction__main" title="<%= description %>"> | |||
There was a problem hiding this comment.
interesting- is title for accessibility?
There was a problem hiding this comment.
This provides a mechanism for the user to see the entire prediction description, since it will overflow with ellipsis if the string is too long
ianguerin
force-pushed
the
feature-1796-pr-3
branch
3 times, most recently
from
be6d824
to
5ed2497
Compare
yvonnesjy
approved these changes
Mar 12, 2024
ianguerin
force-pushed
the
feature-1796-pr-3
branch
2 times, most recently
from
f35c676
to
5057b73
Compare
ianguerin
force-pushed
the
feature-1796-places-autocomplete
branch
from
0b1ff8c
to
92f7005
Compare
ianguerin
force-pushed
the
feature-1796-pr-3
branch
2 times, most recently
from
dc7703c
to
e4c661c
Compare
Add ViewfinderModel which will be used by ViewfinderView in a later commit. Prediction models can be represented by a PredictionView which are in turn managed as an unordered list.
ianguerin
force-pushed
the
feature-1796-pr-3
branch
from
e4c661c
to
5aa928e
Compare
ianguerin
merged commit 6a625b4
into
NCEAS:feature-1796-places-autocomplete
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prediction models can be represented by a PredictionView which are in
turn managed as an unordered list.
#1796