Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light Theme 3: Update map-view.css to use color variables from theme #2298

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Light Theme 3: Update map-view.css to use color variables from theme #2298

merged 2 commits into from
Mar 20, 2024

Conversation

yvonnesjy
Copy link
Collaborator

@yvonnesjy yvonnesjy commented Mar 13, 2024 •
edited
Loading

The changes here limit to coloring only. What it does not include:

  • Spacing adjustment
  • Font size and weight adjustment
  • New design in the layers panel (will be addressed in Layers list polish #2277)
  • Other new designs that require changes to the HTML layout
  • Color update in the navigation help panel that matches the mock. This is because the images used in the touch instructions are white with no borders, making a white background impossible. I did my best to incorporate the new color scheme, but it's only meant to be temporary.
    Design: image
    After this PR: image

Tested on:

  1. PDG:
  • Layers vs layer categories
  • Dark vs light theme
  1. ADC (expected noop)
  2. DRP (expected noop)

@yvonnesjy yvonnesjy force-pushed the feature-2278-3-update-map-view-css branch 3 times, most recently from fcedf9a to f81285f Compare March 19, 2024 00:44
@yvonnesjy
Light Theme: Update map-view.css to use color variables from theme
26cd124 
Tested on:
1. PDG:
    - Layers vs layer categories
    - Dark vs light theme
2. ADC
3. DRP
@yvonnesjy
Fixup: Add tooltip styles
a3c67b8
@yvonnesjy yvonnesjy force-pushed the feature-2278-3-update-map-view-css branch from f81285f to a3c67b8 Compare March 20, 2024 21:53
@yvonnesjy yvonnesjy merged commit 0de3810 into NCEAS:feature-2278-new-portal-theme Mar 20, 2024
1 check passed
@yvonnesjy yvonnesjy linked an issue Apr 11, 2024 that may be closed by this pull request
Update PDG font and color scheme #2278
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianguerin ianguerin ianguerin approved these changes

@robyngit robyngit Awaiting requested review from robyngit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PDG font and color scheme
2 participants
@yvonnesjy @ianguerin