-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme #279
Update readme #279
Conversation
Updated text to 1.4.0 manually for now.
fixed typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
$ mkdir /scratch/myfolder/GwasQcPipeline_v1.2 | ||
$ cd /scratch/myfolder/GwasQcPipeline_v1.2 | ||
$ mkdir /scratch/myfolder/GwasQcPipeline_v1.4.0 | ||
$ cd /scratch/myfolder/GwasQcPipeline_v1.4.0 | ||
$ wget https://repo.anaconda.com/miniconda/Miniconda3-py39_4.12.0-Linux-x86_64.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could simply use wget https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh
to ensure the user always gets the latest version of Miniconda, and so we don't have to update this ever so often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Is there any concern that a later version of Miniconda will present any software version compatibility issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point - but I don't think there is any concern. Miniconda itself is just managing the environment and other software packages. And all the dependencies are specified in the pyproject.toml
file so don't see how it would cause any compatibility issues. With that said, we can talk about it this morning with the group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in group meeting. General consensus was it likely won't cause any issues, but for now will leave as is for the specified Miniconda version and potentially later look into whether latest versions are fine.
Manually updated README installation instructions to version 1.4.0