Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #279

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Update readme #279

merged 2 commits into from
Apr 30, 2024

Conversation

kliao12
Copy link
Contributor

@kliao12 kliao12 commented Apr 25, 2024

Manually updated README installation instructions to version 1.4.0

kliao12 added 2 commits April 25, 2024 10:25
Updated text to 1.4.0 manually for now.
fixed typo
Copy link
Collaborator

@jaamarks jaamarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ mkdir /scratch/myfolder/GwasQcPipeline_v1.2
$ cd /scratch/myfolder/GwasQcPipeline_v1.2
$ mkdir /scratch/myfolder/GwasQcPipeline_v1.4.0
$ cd /scratch/myfolder/GwasQcPipeline_v1.4.0
$ wget https://repo.anaconda.com/miniconda/Miniconda3-py39_4.12.0-Linux-x86_64.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could simply use wget https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh to ensure the user always gets the latest version of Miniconda, and so we don't have to update this ever so often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Is there any concern that a later version of Miniconda will present any software version compatibility issues?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point - but I don't think there is any concern. Miniconda itself is just managing the environment and other software packages. And all the dependencies are specified in the pyproject.toml file so don't see how it would cause any compatibility issues. With that said, we can talk about it this morning with the group.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in group meeting. General consensus was it likely won't cause any issues, but for now will leave as is for the specified Miniconda version and potentially later look into whether latest versions are fine.

@kliao12 kliao12 merged commit efa3ba8 into default Apr 30, 2024
2 checks passed
@kliao12 kliao12 deleted the update-README branch April 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants