bugfix: error when setting case_control_gwas=true
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When setting case_control_gwas = true in the config file, an error
occurred due to a missing subject_level/gwas.txt file.
Cause: The gwas rule requires subject_level/gwas.txt as input. However,
the script used by the agg_population_qc_tables rule generates
this file, but it wasn't listed as an output.
Solution: This commit explicitly adds gwas.txt as an output of the
agg_population_qc_tables rule, ensuring the gwas rule correctly
waits for its dependency before execution.
jaamarks
changed the title
case_control_gwas=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When setting
case_control_gwas = truein the config file, an erroroccurred due to a missing
subject_level/gwas.txtfile.Cause: The
gwasrule requiressubject_level/gwas.txtas input. However,the script used by the
agg_population_qc_tablesrule generatesthis file, but it wasn't listed as an output.
Solution: This commit explicitly adds
gwas.txtas an output of theagg_population_qc_tablesrule, ensuring thegwasrule correctlywaits for its dependency before execution.
Fixes #280