Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: Upgrade Black, Typer, etc (issue #323) #325

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jaamarks
Copy link
Collaborator

This PR upgrades python, black, typer, snakefmt, and importlib-metadata. Our initial goal was to ensure that the Black version for the pre-commit hooks matched the version specified in pyproject.toml, which is what gets executed by the GitHub Actions python-package.yml workflow. However, we needed to upgrade some of the other dependencies in order to get this to work.

Additionally, this PR adds some nice UI enhancements in the terminal, since we upgraded Typer to the latest version.

Previous New
image image

Fixes #323

@jaamarks jaamarks force-pushed the issue-323-update-black branch from d34870f to 267dcde Compare September 19, 2024 19:08
@jaamarks jaamarks force-pushed the issue-323-update-black branch 4 times, most recently from 43ff0f2 to cd98947 Compare September 27, 2024 17:36
Upgrading black required us to also upgrade some additional dependencies
in the `pyproject.toml` and `.pre-commit-config.yml`.
@jaamarks jaamarks force-pushed the issue-323-update-black branch from cd98947 to 59fb49d Compare September 27, 2024 18:24
@jaamarks jaamarks merged commit c28eba1 into default Sep 27, 2024
2 checks passed
@jaamarks jaamarks deleted the issue-323-update-black branch September 27, 2024 18:34
@jaamarks jaamarks changed the title dependencies: Upgrade Black, Typer, etc (issue #323) depends: Upgrade Black, Typer, etc (issue #323) Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black Version Mismatch Between Pre-commit Hooks and GitHub Actions
1 participant