feat: Add max_mem_mb config option to set max memory available (issue #343)
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a ``max_mem_mb`` workflow parameter to the ``config.yml``, similar to the previously added ``max_time_hr`` option. Users can specify the maximum amount of memory (in MB) that they can request on their machine.
jaamarks
changed the title
max_mem_mb config option to set max memory availablemax_mem_mb config option to set max memory available (issue #343)
jaamarks
changed the title
max_mem_mb config option to set max memory available (issue #343)max_mem_mb config option to set max memory available (issue #343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces a new optional workflow parameter for the
config.ymlcalledmax_mem_mb. Users can set this parameter to specify the maximum amount of memory they can request. When this option is set, the memory allocation will be as follows:{1: max_mem / 3, 2: max_mem / 2, 3: max_mem}. This allocation applies only to certain resource-intensive rules.Why
We discovered that some memory-intensive rules, such as
sample_level_ibd, require a significant amount of memory to execute. Previously, we had a fixed allocation request of{1: 1024 * 4, 2: 1024 * 64, 3: 1024 * 250}. However, some users may have constraints on the amount of memory they can request. This new parameter allows them to specify their available memory, enabling more flexible and efficient memory allocation.Fixes #343