fix: cleaner data handling and improved logic for sample_qc_table.py
(issue #324)
#345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the changes introduced in PR #327 to further refine the
sample_qc_table.py
script and address issues related to sample retention.What
_retain_valid_discordant_replicates
function._add_identifiler
function to follow the_add_analytic_exclusion
function._retain_valid_discordant_replicates
function.tests/workflow/scripts/test_sample_qc_table.py
. Added the "is_call_rate_filtered" column to thefake_sample_qc
data fixture.Why
_retain_valid_discordant_replicates
. Refactoring the code to eliminate this dependency resolves those issues._add_identifiler
function to follow the_add_analytic_exclusion
function allows the_retain_valid_discordant_replicates
function to run first, accommodating any status changes to "is_discordant_replicates"._retain_valid_discordant_replicates
function, we aligned our test data with this new expectation.Fixes #324