-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory and time needed for sample_concordance_plink. #362
Conversation
…ped immediately.
… revised concordance_table.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! This looks like it's going to be a massive improvement in computational efficiency. I've tested this on an N=500 sample with success.
sample_concordance_plink
time comparison
previously
start: [Mon Dec 2 13:46:22 2024]
end: [Mon Dec 2 13:52:52 2024]
Current
start: [Tue Dec 3 15:52:06 2024]
end: [Tue Dec 3 15:52:07 2024]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR reduces time and memory requirement for rule
sample_concordance_plink
. It does so by:read_genome.
(789d401).Testing:
Per current default branch, the
sample_concordance_plink
has following performance metrics for a sample of 123,244:With this PR the
sample_concordance_plink
uses 0.9Gb memory and completes in 6.2 minutes.Related issues:
#358, #241, #312