Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV 2469 fix github action #286

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

DEV 2469 fix github action #286

wants to merge 16 commits into from

Conversation

qqiao2024
Copy link
Contributor

No description provided.

@qqiao2024 qqiao2024 marked this pull request as ready for review February 6, 2024 21:13
mpsolano
mpsolano approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@mpsolano mpsolano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/ci.yaml
@@ -5,7 +5,7 @@ on:
- develop
- release/**
- hotfix/**
- feat/dev-583-remove-set-env-in-github-actions
- feat/dev-2469-fix-github-action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for testing? Do we plan to remove this before merging?

jiakf
jiakf approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jiakf jiakf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we should just wait and make sure all the github jobs run and pass before merging

@stilesj-uchicago
Copy link

looks good, we should just wait and make sure all the github jobs run and pass before merging

I don't think that is going to happen. We are using deprecated runners:

@qqiao2024 qqiao2024 marked this pull request as draft February 7, 2024 15:01
@qqiao2024
Copy link
Contributor Author

Converted to draft until we know how to solve this

looks good, we should just wait and make sure all the github jobs run and pass before merging

I don't think that is going to happen. We are using deprecated runners:

* [The Ubuntu 18.04 Actions runner image will begin deprecation on 2022/08/08 and will be fully unsupported by 2023/04/03 actions/runner-images#6002](https://github.com/actions/runner-images/issues/6002)

* [Ubuntu 16.04 environment will be removed on September 20, 2021 actions/runner-images#3287](https://github.com/actions/runner-images/issues/3287)

* [The macOS 10.15 Actions runner image will begin deprecation on 5/31/22 and will be fully unsupported by 12/1/22 for GitHub and ADO actions/runner-images#5583](https://github.com/actions/runner-images/issues/5583)

@jiakf jiakf mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpsolano mpsolano mpsolano approved these changes

@jiakf jiakf jiakf approved these changes

@ProfOak ProfOak ProfOak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qqiao2024 @stilesj-uchicago @ProfOak @jiakf @mpsolano