Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for credentials-file flag #135

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix default value for credentials-file flag #135

merged 1 commit into from
Jan 9, 2023

Conversation

martialblog
Copy link
Member

  • The tilde variable is something that happends in a Shell, therefore it won't work as the default value. We use os.UserHomeDir now

Fixes #133

@martialblog
Fix default value for credentials-file flag
82bbed7 
 - The tilde variable is something that happends in a Shell, therefore it won't
   work as the default value. We use os.UserHomeDir now
@martialblog martialblog added this to the v0.2.0 milestone Jan 9, 2023
@pdorschner pdorschner self-requested a review January 9, 2023 15:26
pdorschner
pdorschner approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@pdorschner pdorschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martialblog martialblog merged commit bf1ba07 into main Jan 9, 2023
@martialblog martialblog deleted the fix/default-home-dir branch January 10, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdorschner pdorschner pdorschner approved these changes

@RincewindsHat RincewindsHat Awaiting requested review from RincewindsHat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Default-Credentials funktionieren nicht mehr
2 participants
@martialblog @pdorschner