Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: grid): change API OnClick to onClick #394

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #394 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   89.31%   89.36%   +0.05%     
==========================================
  Files         320      320              
  Lines        7093     7093              
  Branches      568      568              
==========================================
+ Hits         6335     6339       +4     
+ Misses        587      583       -4     
  Partials      171      171
Impacted Files Coverage Δ
components/grid/grid.component.ts 94.11% <100%> (ø) ⬆️
components/picker/picker.component.ts 81.97% <0%> (+1.74%) ⬆️
components/picker/picker.service.ts 94.44% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9af23...b0f9295. Read the comment docs.

@fisherspy fisherspy merged commit bf3039a into NG-ZORRO:master Apr 23, 2019
@fisherspy fisherspy mentioned this pull request Apr 30, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants