fix: remove entryComponents

NG-ZORRO · Mar 10, 2020 · 5fb0215 · 5fb0215
1 parent 886055a
commit 5fb0215
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 16 deletions.
diff --git a/components/message/message-container.component.ts b/components/message/message-container.component.ts
@@ -65,13 +65,7 @@ export class NzMessageContainerComponent implements OnInit, OnDestroy {
     message.onClose = new Subject<boolean>();
     this.messages = [...this.messages, message];
 
-    const cdr = this.cdr;
-
-    console.log('debug messages length', this.messages, cdr);
-
-    // Bug should happen here. messages get updated but change detection failed.
-    cdr.detectChanges();
-    cdr.markForCheck();
+    this.cdr.markForCheck();
   }
 
   /**

diff --git a/components/message/message.module.ts b/components/message/message.module.ts
@@ -18,7 +18,6 @@ import { NzMessageServiceModule } from './message.service.module';
 
 @NgModule({
   imports: [CommonModule, OverlayModule, NzIconModule, NzOutletModule, NzMessageServiceModule],
-  declarations: [NzMessageContainerComponent, NzMessageComponent],
-  entryComponents: [NzMessageContainerComponent, NzMessageComponent]
+  declarations: [NzMessageContainerComponent, NzMessageComponent]
 })
 export class NzMessageModule {}
diff --git a/components/notification/notification.module.ts b/components/notification/notification.module.ts
@@ -18,7 +18,6 @@ import { NzNotificationServiceModule } from './notification.service.module';
 
 @NgModule({
   imports: [CommonModule, OverlayModule, NzIconModule, NzNotificationServiceModule, NzOutletModule],
-  declarations: [NzNotificationComponent, NzNotificationContainerComponent],
-  entryComponents: [NzNotificationContainerComponent]
+  declarations: [NzNotificationComponent, NzNotificationContainerComponent]
 })
 export class NzNotificationModule {}
diff --git a/components/popconfirm/popconfirm.module.ts b/components/popconfirm/popconfirm.module.ts
@@ -31,7 +31,6 @@ import { NzPopconfirmComponent, NzPopconfirmDirective } from './popconfirm';
     NzOverlayModule,
     NzNoAnimationModule,
     NzToolTipModule
-  ],
-  entryComponents: [NzPopconfirmComponent]
+  ]
 })
 export class NzPopconfirmModule {}
diff --git a/components/popover/popover.module.ts b/components/popover/popover.module.ts
@@ -16,7 +16,6 @@ import { NzToolTipModule } from 'ng-zorro-antd/tooltip';
 import { NzPopoverComponent, NzPopoverDirective } from './popover';
 
 @NgModule({
-  entryComponents: [NzPopoverComponent],
   exports: [NzPopoverDirective, NzPopoverComponent],
   declarations: [NzPopoverDirective, NzPopoverComponent],
   imports: [CommonModule, OverlayModule, NzOutletModule, NzOverlayModule, NzNoAnimationModule, NzToolTipModule]

diff --git a/components/tooltip/tooltip.module.ts b/components/tooltip/tooltip.module.ts
@@ -17,7 +17,6 @@ import { NzToolTipComponent, NzTooltipDirective } from './tooltip';
 @NgModule({
   declarations: [NzToolTipComponent, NzTooltipDirective],
   exports: [NzToolTipComponent, NzTooltipDirective],
-  imports: [CommonModule, OverlayModule, NzOutletModule, NzOverlayModule, NzNoAnimationModule],
-  entryComponents: [NzToolTipComponent]
+  imports: [CommonModule, OverlayModule, NzOutletModule, NzOverlayModule, NzNoAnimationModule]
 })
 export class NzToolTipModule {}