fix(module:carousel): throw error when changing rtl (#6318)

close #6301
NG-ZORRO · Jan 7, 2021 · bef7e29 · bef7e29
1 parent a2cc9a7
commit bef7e29
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 24 deletions.
diff --git a/components/carousel/carousel.component.ts b/components/carousel/carousel.component.ts
@@ -92,8 +92,7 @@ const NZ_CONFIG_MODULE_NAME: NzConfigKey = 'carousel';
     </ng-template>
   `,
   host: {
-    '[class.ant-carousel-vertical]': 'vertical',
-    '[class.ant-carousel-rtl]': `dir ==='rtl'`
+    '[class.ant-carousel-vertical]': 'vertical'
   }
 })
 export class NzCarouselComponent implements AfterContentInit, AfterViewInit, OnDestroy, OnChanges, OnInit {
@@ -173,7 +172,6 @@ export class NzCarouselComponent implements AfterContentInit, AfterViewInit, OnD
     this.dir = this.directionality.value;
     this.directionality.change?.pipe(takeUntil(this.destroy$)).subscribe((direction: Direction) => {
       this.dir = direction;
-      this.switchStrategy();
     });
   }
 

diff --git a/components/carousel/carousel.spec.ts b/components/carousel/carousel.spec.ts
@@ -277,27 +277,6 @@ describe('carousel', () => {
     // Already covered in components specs.
     // describe('opacity strategy', () => {});
   });
-
-  describe('RTL', () => {
-    let fixture: ComponentFixture<NzTestCarouselRtlComponent>;
-    let carouselWrapper: DebugElement;
-
-    beforeEach(() => {
-      fixture = TestBed.createComponent(NzTestCarouselRtlComponent);
-      fixture.detectChanges();
-      carouselWrapper = fixture.debugElement.query(By.directive(NzCarouselComponent));
-    });
-
-    it('should className correct', () => {
-      fixture.detectChanges();
-      expect(carouselWrapper.nativeElement.classList).toContain('ant-carousel-rtl');
-
-      fixture.componentInstance.direction = 'ltr';
-      fixture.detectChanges();
-
-      expect(carouselWrapper.nativeElement.classList).not.toContain('ant-carousel-rtl');
-    });
-  });
 });
 
 describe('carousel custom strategies', () => {