fix(module:tooptip): fix setTitle proxy to nzTitle

close #2695
NG-ZORRO · Dec 27, 2018 · cbdf6dc · cbdf6dc
1 parent 5c5a82d
commit cbdf6dc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/components/tooltip/nz-tooltip.directive.ts b/components/tooltip/nz-tooltip.directive.ts
@@ -24,7 +24,7 @@ import { NzToolTipComponent } from './nz-tooltip.component';
 
 @Directive({
   selector: '[nz-tooltip]',
-  host: {
+  host    : {
     '[class.ant-tooltip-open]': 'isTooltipOpen'
   }
 })
@@ -165,6 +165,11 @@ export class NzTooltipDirective implements AfterViewInit, OnChanges, OnInit, OnD
           this.updateCompValue(key, change.currentValue);
         }
       });
+
+      if (changes.setTitle) {
+        this.nzTitle = changes.setTitle.currentValue;
+        this.updateCompValue('nzTitle', changes.setTitle.currentValue);
+      }
     }
   }
 }
diff --git a/components/tooltip/nz-tooltip.spec.ts b/components/tooltip/nz-tooltip.spec.ts
@@ -239,14 +239,24 @@ describe('NzTooltip', () => {
       expect(triggerElement.nextSibling.tagName).toBe('BUTTON');
     }));
 
+    it('should set `setTitle` proxy to `nzTitle`', () => {
+      fixture.detectChanges();
+      const tooltipComponent = (component.titleStringNzTooltipDirective as any).tooltip as NzToolTipComponent; // tslint:disable-line:no-any
+      expect(tooltipComponent.nzTitle).toBe('title-string');
+
+      component.title = 'changed!';
+      fixture.detectChanges();
+      expect(tooltipComponent.nzTitle).toBe('changed!');
+    });
+
   });
 
 });
 
 @Component({
   selector: 'nz-tooltip-test-new',
   template: `
-    <a #titleString nz-tooltip nzTitle="title-string" nzTrigger="hover" nzPlacement="topLeft" nzOverlayClassName="testClass" [nzOverlayStyle]="{color:'#000'}"
+    <a #titleString nz-tooltip [nzTitle]="title" nzTrigger="hover" nzPlacement="topLeft" nzOverlayClassName="testClass" [nzOverlayStyle]="{color:'#000'}"
        [nzMouseEnterDelay]="0.15" [nzMouseLeaveDelay]="0.1">Show</a>
     <a #titleTemplate nz-tooltip [nzTitle]="template">Show</a>
     <ng-template #template>
@@ -266,6 +276,8 @@ export class NzTooltipTestNewComponent {
   @ViewChild('titleTemplate', { read: NzTooltipDirective }) titleTemplateNzTooltipDirective: NzTooltipDirective;
   @ViewChild('inBtnGroup') inBtnGroup: ElementRef;
 
+  title = 'title-string';
+
 }
 
 @Component({