Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling close of NzContextMenuService when no context menu is opened would lead to error #3768

Closed
wzhudev opened this issue Jul 11, 2019 · 0 comments · Fixed by #3782
Closed

calling close of NzContextMenuService when no context menu is opened would lead to error #3768

wzhudev opened this issue Jul 11, 2019 · 0 comments · Fixed by #3782
Assignees
@vthinkxie
Labels
Component: Dropdown 💪 Enhancement

Comments

@wzhudev
Copy link
Member

wzhudev commented Jul 11, 2019 

LeftDataSourceComponent.html:2 ERROR TypeError: Cannot read property 'detach' of undefined
    at NzContextMenuService.close (ng-zorro-antd-dropdown.js:973)
    at LeftDataSourceComponent.clickOutSideMenu (index.ts:53)
    at Object.eval [as handleEvent] (LeftDataSourceComponent.html:2)
    at handleEvent (core.js:34789)
    at callWithDebugContext (core.js:36407)
    at Object.debugHandleEvent [as handleEvent] (core.js:36043)
    at dispatchEvent (core.js:22533)
    at core.js:24430
    at SafeSubscriber.schedulerFn [as _next] (core.js:27889)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:183)
@vthinkxie vthinkxie mentioned this issue Jul 13, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Jul 13, 2019
@vthinkxie
fix(module:dropdown): fix dropdown contextmenu (#3782)
cce920d 
close #3768
lppedd pushed a commit to lppedd/ng-zorro-antd that referenced this issue Jul 15, 2019
@vthinkxie @lppedd
fix(module:dropdown): fix dropdown contextmenu (NG-ZORRO#3782)
b0943b5 
close NG-ZORRO#3768
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
fix(module:dropdown): fix dropdown contextmenu (NG-ZORRO#3782)
88e4846 
close NG-ZORRO#3768
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
fix(module:dropdown): fix dropdown contextmenu (NG-ZORRO#3782)
451ecd0 
close NG-ZORRO#3768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
Component: Dropdown 💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:dropdown): fix dropdown contextmenu
2 participants
@vthinkxie @wzhudev