Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzPrefixIcon in nz-input-group has a hardcoded style that brakes scss theme #3950

Closed
Dimanoid opened this issue Aug 8, 2019 · 1 comment · Fixed by #4764
Closed

nzPrefixIcon in nz-input-group has a hardcoded style that brakes scss theme #3950

Dimanoid opened this issue Aug 8, 2019 · 1 comment · Fixed by #4764

Comments

@Dimanoid
Copy link

Dimanoid commented Aug 8, 2019

Code link

<i nz-icon [nzType]="nzPrefixIcon" *ngIf="nzPrefixIcon" style="color: rgba(0, 0, 0, 0.25)"></i>

Steps to reproduce

nz-input-group.component.html
line 23
<i nz-icon [nzType]="nzPrefixIcon" *ngIf="nzPrefixIcon" style="color: rgba(0, 0, 0, 0.25)">

What is expected?

nz-input-group should not to have hardcoded color style in template

What is actually happening?

Icons color defined in theme.less is overridden by hardcoded style in nz-input-group template

Environment Info
ng-zorro-antd 8.1.2
Browser any
@wzhudev
Copy link
Member

wzhudev commented Aug 8, 2019

Yes. The reason why we wrote this is that antd doesn't provide this style in less files. See https://ant.design/components/input/#components-input-demo-presuffix.

屏幕快照 2019-08-08 下午9 44 20

Could you please open an issue there first? https://github.com/ant-design/ant-design

@wzhudev wzhudev removed their assignment Sep 13, 2019
@vthinkxie vthinkxie added this to the 9.0.0 milestone Feb 10, 2020
vthinkxie pushed a commit that referenced this issue Feb 10, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants