-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(module:carousel): remove vertical api #4376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
added
PR: target-major
💔 Breaking Change
This PR or the solution to this issue would introduce breaking changes
labels
Nov 8, 2019
wzhudev
force-pushed
the
remove-carousel-api
branch
from
November 22, 2019 05:05
f7bbb1c
to
023929d
Compare
Codecov Report
@@ Coverage Diff @@
## master #4376 +/- ##
==========================================
- Coverage 93.23% 93.22% -0.02%
==========================================
Files 519 519
Lines 12822 12817 -5
Branches 2013 2013
==========================================
- Hits 11955 11949 -6
Misses 452 452
- Partials 415 416 +1
Continue to review full report at Codecov.
|
hsuanxyz
changed the title
feat(module:carousel): remove vertical api
chore(module:carousel): remove vertical api
Nov 22, 2019
Deploy preview for ng-zorro-master ready! Built with commit e0ba248 |
fix(module:carousel): fix template
wzhudev
force-pushed
the
remove-carousel-api
branch
from
December 31, 2019 12:01
e0ba248
to
62b459f
Compare
hsuanxyz
approved these changes
Jan 8, 2020
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:carousel): remove vertical api BREAKING CHANGE: Carousel - `nzVertical` is removed. Please use 'nzDotPosition' instead.
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:carousel): remove vertical api BREAKING CHANGE: Carousel - `nzVertical` is removed. Please use 'nzDotPosition' instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💔 Breaking Change
This PR or the solution to this issue would introduce breaking changes
PR: merge-ready
PR: merged
PR: target-major
PR: unreviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information