Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:carousel): remove vertical api #4376

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: remove nzVertical API of carousel component

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@pr-triage pr-triage bot added the PR: draft label Nov 4, 2019
@wzhudev wzhudev added this to the 9.0.0 milestone Nov 8, 2019
@wzhudev wzhudev added PR: target-major 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes labels Nov 8, 2019
@wzhudev wzhudev marked this pull request as ready for review November 22, 2019 04:59
@auto-assign auto-assign bot requested a review from cipchk November 22, 2019 04:59
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #4376 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4376      +/-   ##
==========================================
- Coverage   93.23%   93.22%   -0.02%     
==========================================
  Files         519      519              
  Lines       12822    12817       -5     
  Branches     2013     2013              
==========================================
- Hits        11955    11949       -6     
  Misses        452      452              
- Partials      415      416       +1
Impacted Files Coverage Δ
components/carousel/nz-carousel.component.ts 93.15% <ø> (-0.23%) ⬇️
components/time-picker/time-holder.ts 96.64% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 137337e...4a0ab90. Read the comment docs.

@hsuanxyz hsuanxyz changed the title feat(module:carousel): remove vertical api chore(module:carousel): remove vertical api Nov 22, 2019
@netlify
Copy link

netlify bot commented Nov 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e0ba248

https://deploy-preview-4376--ng-zorro-master.netlify.com

fix(module:carousel): fix template
@hsuanxyz hsuanxyz merged commit 37aa921 into NG-ZORRO:master Jan 8, 2020
@wzhudev wzhudev deleted the remove-carousel-api branch January 11, 2020 07:50
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:carousel): remove vertical api

BREAKING CHANGE:

Carousel
 - `nzVertical` is removed. Please use 'nzDotPosition' instead.
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:carousel): remove vertical api

BREAKING CHANGE:

Carousel
 - `nzVertical` is removed. Please use 'nzDotPosition' instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: merge-ready PR: merged PR: target-major PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants