Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden nz-option can still be selected by the keyboard #4377

Closed
QichenZhu opened this issue Nov 4, 2019 · 0 comments
Closed

Hidden nz-option can still be selected by the keyboard #4377

QichenZhu opened this issue Nov 4, 2019 · 0 comments
Assignees
@vthinkxie
Labels
🐛 Bug Component: Select

Comments

@QichenZhu
Copy link
Contributor

Reproduction link

https://ng-zorro-antd-start-n3rnaj.stackblitz.io/

Steps to reproduce

  1. Run the demo app
  2. Click the select box
  3. Press the Down Arrow key twice
  4. Press the Enter key

What is expected?

Option "A" should be selected.

What is actually happening?

Hidden option "B" is selected.

Environment Info
ng-zorro-antd 8.4.1
Browser Google Chrome 78.0.3904.70
QichenZhu added a commit to QichenZhu/ng-zorro-antd that referenced this issue Nov 5, 2019
@QichenZhu
fix(module:select): prevent hidden options from being selected (NG-ZO…
04d463d 
…RRO#4377)
@QichenZhu QichenZhu mentioned this issue Nov 5, 2019
Merged
3 tasks
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@QichenZhu @Ricbet
fix(module:select): prevent hidden options from being selected (NG-ZO…
23d47d9 
…RRO#4382)

* fix(module:select): prevent hidden options from being selected (NG-ZORRO#4377)

* fix(module:select): add test cases

* fix(module:select): fix test cases

close NG-ZORRO#4377
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
Closed
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@QichenZhu @chensimeng
fix(module:select): prevent hidden options from being selected (NG-ZO…
6818439 
…RRO#4382)

* fix(module:select): prevent hidden options from being selected (NG-ZORRO#4377)

* fix(module:select): add test cases

* fix(module:select): fix test cases

close NG-ZORRO#4377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
🐛 Bug Component: Select
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vthinkxie @QichenZhu