Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default nz-empty image does not support dark mode (well it looks bad) #4921

Closed
whittssg opened this issue Mar 22, 2020 · 1 comment · Fixed by #4924
Closed

Default nz-empty image does not support dark mode (well it looks bad) #4921

whittssg opened this issue Mar 22, 2020 · 1 comment · Fixed by #4924
Labels
Component: Empty 💪 Enhancement

Comments

@whittssg
Copy link

Reproduction link

[https://stackblitz.com/edit/ng-zorro-antd-start = > https://ng.ant.design/version/next/components/empty/en](https://stackblitz.com/edit/ng-zorro-antd-start = > https://ng.ant.design/version/next/components/empty/en)

Steps to reproduce

Go to https://ng.ant.design/version/next/components/empty/en and see how the default images look bad in dark mode.

What is expected?

They dont look bad

What is actually happening?

They look bad

Environment Info
ng-zorro-antd 9.0.0-beta.2
Browser Latest Chrome
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Mar 23, 2020
fix(module:empty): fix empty image style in dark mode
63a4587 
close NG-ZORRO#4921
@wzhudev wzhudev mentioned this issue Mar 23, 2020
Merged
3 tasks
@wzhudev
Copy link
Member

wzhudev commented Mar 23, 2020

@whittssg Thanks for opening this! This will be fixed in beta.3 or something.

vthinkxie pushed a commit that referenced this issue Mar 23, 2020
fix(module:empty): fix empty image style in dark mode (#4924)
bae59d7 
close #4921
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
fix(module:empty): fix empty image style in dark mode (NG-ZORRO#4924)
b30599b 
close NG-ZORRO#4921
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
Closed
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
fix(module:empty): fix empty image style in dark mode (NG-ZORRO#4924)
7cf630c 
close NG-ZORRO#4921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Empty 💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:empty): fix empty image style in dark mode wzhudev/ng-zorro-antd
2 participants
@whittssg @wzhudev