Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:empty): fix empty image style in dark mode #4924

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 23, 2020

close #4921

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4921

The empty image looks strangly white in dark mode.

What is the new behavior?

The empty image looks good in dark mode.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 23, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #4924 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4924      +/-   ##
==========================================
- Coverage    91.5%   91.49%   -0.02%     
==========================================
  Files         538      538              
  Lines       13764    13764              
  Branches     2044     2044              
==========================================
- Hits        12595    12593       -2     
- Misses        700      701       +1     
- Partials      469      470       +1
Impacted Files Coverage Δ
components/empty/partial/default.ts 100% <ø> (ø) ⬆️
components/empty/partial/simple.ts 100% <ø> (ø) ⬆️
components/core/util/text-measure.ts 89.56% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03744e3...63a4587. Read the comment docs.

@vthinkxie vthinkxie merged commit bae59d7 into NG-ZORRO:master Mar 23, 2020
@wzhudev wzhudev deleted the empty-dark-mode-image branch March 23, 2020 03:31
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default nz-empty image does not support dark mode (well it looks bad)
3 participants