Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click Event for NzNotification #4986

Closed
WeslleyDeSouza opened this issue Apr 5, 2020 · 1 comment
Closed

Click Event for NzNotification #4986

WeslleyDeSouza opened this issue Apr 5, 2020 · 1 comment
Assignees
@wzhudev
Labels
Component: Notification 🌈 Feature Request help wanted

Comments

@WeslleyDeSouza
Copy link

What problem does this feature solve?

Get user interation with the NzNotification

What does the proposed API look like?

this.notification.blank(
'Notification Title',
'Hello World.',
{
nzOnClick:()=>{}
}
);
@wzhudev
Copy link
Member

wzhudev commented Apr 5, 2020 •
edited
Loading

PR welcome! Better to make it an observable property of NzNotificationDataFilled rather than a callback.

wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Apr 14, 2020
feat(module:notification): add onClose observable
9326151 
close NG-ZORRO#4986

BREAKING CHANGE: NzMessageDataFilled is replaced by NzMessageRef
BREAKING CHANGE: NzNotificationDataFilled is replaced by NzNotificationRef
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Apr 14, 2020
feat(module:notification): add onClick observable
4949d0b 
close NG-ZORRO#4986

BREAKING CHANGE: NzMessageDataFilled is replaced by NzMessageRef
BREAKING CHANGE: NzNotificationDataFilled is replaced by NzNotificationRef
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Apr 14, 2020
@hsuanxyz
feat(module:notification): add onClick observable
2537739 
close NG-ZORRO#4986

BREAKING CHANGE: NzMessageDataFilled is replaced by NzMessageRef
BREAKING CHANGE: NzNotificationDataFilled is replaced by NzNotificationRef

Update components/message/typings.ts

Co-Authored-By: Hsuan Lee <HsuanGM@gmail.com>

Update components/notification/typings.ts

Co-Authored-By: Hsuan Lee <HsuanGM@gmail.com>
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
Closed
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
feat(module:notification): add onClick observable (NG-ZORRO#4989)
c4a9f5a 
close NG-ZORRO#4986

BREAKING CHANGE: 


- NzMessageDataFilled is replaced by NzMessageRef
- NzNotificationDataFilled is replaced by NzNotificationRef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
Component: Notification 🌈 Feature Request help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wzhudev @WeslleyDeSouza