feat(module:notification): add onClick observable #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4989 +/- ##
==========================================
- Coverage 91.48% 91.43% -0.05%
==========================================
Files 538 550 +12
Lines 13738 13709 -29
Branches 2043 2111 +68
==========================================
- Hits 12568 12535 -33
- Misses 707 712 +5
+ Partials 463 462 -1
Continue to review full report at Codecov.
|
|
notification API 文档没改，还是 |
hsuanxyz
reviewed
Apr 13, 2020
hsuanxyz
reviewed
Apr 13, 2020
wzhudev
force-pushed
the
notification-click
branch
from
772d6e6 to
9326151
Compare
wzhudev
changed the title
wzhudev
force-pushed
the
notification-click
branch
from
9326151 to
4949d0b
Compare
hsuanxyz
previously approved these changes
Apr 14, 2020
hsuanxyz
reviewed
Apr 14, 2020
close NG-ZORRO#4986 BREAKING CHANGE: NzMessageDataFilled is replaced by NzMessageRef BREAKING CHANGE: NzNotificationDataFilled is replaced by NzNotificationRef Update components/message/typings.ts Co-Authored-By: Hsuan Lee <HsuanGM@gmail.com> Update components/notification/typings.ts Co-Authored-By: Hsuan Lee <HsuanGM@gmail.com>
wzhudev
force-pushed
the
notification-click
branch
from
229fb52 to
2537739
Compare
hsuanxyz
approved these changes
Apr 14, 2020
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
close NG-ZORRO#4986 BREAKING CHANGE: - NzMessageDataFilled is replaced by NzMessageRef - NzNotificationDataFilled is replaced by NzNotificationRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor message and notification
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
NzNotificationDataFilledis replaced byNzNotificationRef.NzMessageDataFilledis replaced byNzMessageRef.Doing this to make these two components' API consistent with others', and to stop exposing some internal implementation details.
Other information