Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NzPickerComponent in Server Side Rendering cause "ERROR ReferenceError: window is not defined" error. #5630

Closed
emondora opened this issue Jul 30, 2020 · 1 comment

Comments

@emondora
Copy link
Contributor

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-ivy-1zmwds?embed=1&file=src/app/app.component.ts

Steps to reproduce

Angular Universal: Server Side Rendering
Step 1: Add NzRangePicker into a page;
Step 2: Visit the Page which contains NzRangePicker in "Angular Universal Server Side Rendering";
Step 3: Node.js SSR render the page which contains NzRangePicker;
Step 4: Node.js console logs "ERROR ReferenceError: window is not defined at ng_zorro_antd_date_picker_NzPickerComponent.ngAfterViewInit"

What is expected?

Angular Universal: Server Side Rendering
There Should No "window is not defined" error.

What is actually happening?

Angular Universal: Server Side Rendering
ERROR ReferenceError: window is not defined at ng_zorro_antd_date_picker_NzPickerComponent.ngAfterViewInit

Environment Info
ng-zorro-antd 9.3.0
Browser Chrome, Angular Universal Express Engine
@zorro-bot
Copy link

zorro-bot bot commented Jul 30, 2020

Hello @emondora. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @emondora, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants