Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): window is not defined #5640

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

emondora
Copy link
Contributor

@emondora emondora commented Aug 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5630

What is the new behavior?

When Sever Side Rendering there is no more "ERROR ReferenceError: window is not defined at ng_zorro_antd_date_picker_NzPickerComponent.ngAfterViewInit"

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@emondora emondora requested a review from wenqi73 as a code owner August 3, 2020 02:34
@zorro-bot
Copy link

zorro-bot bot commented Aug 3, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #5640 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5640      +/-   ##
==========================================
+ Coverage   90.29%   90.30%   +0.01%     
==========================================
  Files         455      455              
  Lines       13786    13787       +1     
  Branches     2258     2258              
==========================================
+ Hits        12448    12451       +3     
+ Misses        820      818       -2     
  Partials      518      518              
Impacted Files Coverage Δ
components/date-picker/picker.component.ts 95.94% <100.00%> (+0.02%) ⬆️
components/tabs/tab-nav-bar.component.ts 85.51% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ede777...6a8ed68. Read the comment docs.

@wenqi73 wenqi73 changed the title fix(module:date-picker): fix Angular Universal SSR error window is not defined fix(module:date-picker): window is not defined Aug 3, 2020
@wenqi73 wenqi73 merged commit f5899ad into NG-ZORRO:master Aug 3, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants