Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzOnCalendarChange event not being emitted on nz-range-picker with time #5782

Closed
jtgferreira opened this issue Sep 15, 2020 · 0 comments · Fixed by #5790
Closed

nzOnCalendarChange event not being emitted on nz-range-picker with time #5782

jtgferreira opened this issue Sep 15, 2020 · 0 comments · Fixed by #5790

Comments

@jtgferreira
Copy link

Reproduction link

https://stackblitz.com/edit/nzoncalendarchange-issue?

Steps to reproduce

1 - Set nz-range-picker with showTime

2 - Bind the nzOnCalendarChange event

3 - Select start/end date with time

What is expected?

nzOnCalendarChange should emit the selected date(s)

What is actually happening?

nzOnCalendarChange doesn't emit any event when we set the nz-range-picker with showTime option

Environment Info
ng-zorro-antd 9.3.0
Browser Chrome

Check the example on the link and test both time and without time range picker.

I've looked up the github code and found that here:

changeValueFromSelect(value: CandyDate, emitValue: boolean = true): void {
the method responsible for triggering the origin of nzOnCalendarChange event receives the param emitValue as false based on the variable showTime. Like here, for instance:
(selectDate)="changeValueFromSelect($event, !showTime)"

Is there any explanation for this?

I need this event to be able do disable the dates upon user date selection. Since ng-zorro is the main design system on our company and we use it all around our products, this is an important issue for us.
Thanks in advance,

João Ferreira, Stratio Automotive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants