Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): arrow icon can be used when not using single-select #5785

Merged
merged 3 commits into from
Sep 16, 2020

Conversation

DepickereSven
Copy link
Contributor

@DepickereSven DepickereSven commented Sep 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5575

What is the new behavior?

That you can use the arrow icon in multi-select and tag mode.
But by default it's false. So you need to set it true in multi and tag mode.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #5785 into master will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5785      +/-   ##
==========================================
- Coverage   90.31%   90.09%   -0.22%     
==========================================
  Files         455      455              
  Lines       13788    13857      +69     
  Branches     2258     2185      -73     
==========================================
+ Hits        12452    12484      +32     
- Misses        819      849      +30     
- Partials      517      524       +7     
Impacted Files Coverage Δ
components/select/select.component.ts 87.67% <100.00%> (+0.17%) ⬆️
components/tabs/tab-link.directive.ts 37.50% <0.00%> (-62.50%) ⬇️
components/tabs/tabset.component.ts 86.20% <0.00%> (-10.21%) ⬇️
components/carousel/strategies/base-strategy.ts 83.33% <0.00%> (-7.58%) ⬇️
components/tabs/tabs-ink-bar.directive.ts 83.87% <0.00%> (-3.23%) ⬇️
components/tabs/tab-nav-operation.component.ts 59.37% <0.00%> (-2.70%) ⬇️
components/i18n/date-helper.service.ts 85.00% <0.00%> (-2.50%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (-2.48%) ⬇️
components/breadcrumb/breadcrumb.component.ts 97.87% <0.00%> (-2.13%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5899ad...53d1f0d. Read the comment docs.

@vthinkxie
Copy link
Member

LGTM
thanks for your PR!

@github-actions
Copy link

github-actions bot commented Sep 16, 2020

😭 Deploy PR Preview bb8677c failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants