Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): icons not showing multi (#5575 #5568) #5650

Closed
wants to merge 2 commits into from

Conversation

DepickereSven
Copy link
Contributor

close #5575 #5568

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5575 and #5568

What is the new behavior?

Arrow icon and search icon can be used in multi mode

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Aug 5, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #5650 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5650      +/-   ##
==========================================
+ Coverage   90.04%   90.05%   +0.01%     
==========================================
  Files         455      455              
  Lines       13847    13847              
  Branches     2266     2266              
==========================================
+ Hits        12468    12470       +2     
+ Misses        852      851       -1     
+ Partials      527      526       -1     
Impacted Files Coverage Δ
components/select/select.component.ts 87.54% <ø> (ø)
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1afabd4...1a2f95a. Read the comment docs.

@DepickereSven
Copy link
Contributor Author

@vthinkxie

Some screenshots to prove that it works

Screenshot_2020-09-08 NG-ZORRO - Ant Design Of Angular(1)
Screenshot_2020-09-08 NG-ZORRO - Ant Design Of Angular

@vthinkxie
Copy link
Member

Hi @DepickereSven

按照 ant design 设计规范,在多选模式下是没有下拉箭头的,在 9.x 之后同步了 antd 4.x 的设计规范,因此多选箭头被移除了,这是在预期中的,不是一个bug

感谢你的 PR

@vthinkxie vthinkxie closed this Sep 15, 2020
@DepickereSven
Copy link
Contributor Author

@vthinkxie

By ant-design are you referring to this library https://github.com/ant-design/ant-design/?

Because when I look in their docs I find the following:

Schermafbeelding 2020-09-15 om 11 51 16

So for multi-select and tags is by default on false. But it's possible to set the showArrow on true so you can see it.

Like you can see in the following example the icons work in multi and tag mode.

https://stackblitz.com/edit/react-vrppip?file=index.js

@Hx2heng
Copy link

Hx2heng commented Oct 10, 2020

Hi @DepickereSven

按照 ant design 设计规范,在多选模式下是没有下拉箭头的,在 9.x 之后同步了 antd 4.x 的设计规范,因此多选箭头被移除了,这是在预期中的,不是一个bug

感谢你的 PR

在多选模式下,设置nzShowArrow为true没有箭头出现。(ng-zorro 版本9.3.0)

@DepickereSven
Copy link
Contributor Author

@Hx2heng

This has been solved in the following PR #5785.
This PR is included in version 10.0.0.
So it's normal that it doesn't work in 9.3.0.

So to get this bug solved I would suggest you upgrade to Angular 10. So you can use ng-zorro 10.0.0.
Changelog of version 10.0.0 => https://github.com/NG-ZORRO/ng-zorro-antd/releases/tag/10.0.0

@Hx2heng
Copy link

Hx2heng commented Oct 12, 2020

@DepickereSven Thanks.

@zds-d
Copy link

zds-d commented Jan 15, 2021

In version 10.x, tree-select component already has nzShowArrow property, but nz-tree-select component still does not have this property
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is show arrrow not avaible on multi or tag select
4 participants