-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): icons not showing multi (#5575 #5568) #5650
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5650 +/- ##
==========================================
+ Coverage 90.04% 90.05% +0.01%
==========================================
Files 455 455
Lines 13847 13847
Branches 2266 2266
==========================================
+ Hits 12468 12470 +2
+ Misses 852 851 -1
+ Partials 527 526 -1
Continue to review full report at Codecov.
|
Some screenshots to prove that it works |
按照 ant design 设计规范,在多选模式下是没有下拉箭头的,在 9.x 之后同步了 antd 4.x 的设计规范,因此多选箭头被移除了,这是在预期中的,不是一个bug 感谢你的 PR |
By ant-design are you referring to this library https://github.com/ant-design/ant-design/? Because when I look in their docs I find the following: So for multi-select and tags is by default on false. But it's possible to set the showArrow on true so you can see it. Like you can see in the following example the icons work in multi and tag mode. |
在多选模式下,设置nzShowArrow为true没有箭头出现。(ng-zorro 版本9.3.0) |
This has been solved in the following PR #5785. So to get this bug solved I would suggest you upgrade to Angular 10. So you can use ng-zorro 10.0.0. |
@DepickereSven Thanks. |
close #5575 #5568
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5575 and #5568
What is the new behavior?
Arrow icon and search icon can be used in multi mode
Does this PR introduce a breaking change?
Other information